From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RLJGQ-0007Xf-EQ
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 14:40:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1RLJGK-0003f2-J5
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 14:40:46 -0400
Message-ID: <4EB03CDA.1030405@web.de>
Date: Tue, 01 Nov 2011 19:39:22 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1320140389-22079-1-git-send-email-sunshine@sunshineco.com>
In-Reply-To: <1320140389-22079-1-git-send-email-sunshine@sunshineco.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qemu-barrier: Fix build failure on PowerPC
 Mac OS X
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

Am 01.11.2011 10:39, schrieb Eric Sunshine:
> qemu-barrier.h tests if macro __powerpc__ is defined, however, the
> preprocessor on PowerPC Mac OS X defines only __POWERPC__, not
> __powerpc__.

> Resolve by testing instead for qemu-provided _ARCH_PPC.

This part is actually wrong: _ARCH_PPC is compiler-provided.

>=20
> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>

I currently don't have access to my ppc64 box, so

Reviewed-by: Andreas F=E4rber <andreas.faerber@web.de>

Next time please cc malc (TCG ppc) and me (Darwin) on this.

Thanks,
Andreas

> ---
>=20
> The anomalous __powerpc__ test appears only in qemu-barrier.h.
> No other source files reference this name.
>=20
> Cc: David Gibson <david@gibson.dropbear.id.au>
>=20
>  qemu-barrier.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/qemu-barrier.h b/qemu-barrier.h
> index 735eea6..c11bb2b 100644
> --- a/qemu-barrier.h
> +++ b/qemu-barrier.h
> @@ -14,7 +14,7 @@
>   */
>  #define smp_wmb()   barrier()
> =20
> -#elif defined(__powerpc__)
> +#elif defined(_ARCH_PPC)
> =20
>  /*
>   * We use an eieio() for a wmb() on powerpc.  This assumes we don't