From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLJT9-0002QI-LS for qemu-devel@nongnu.org; Tue, 01 Nov 2011 14:53:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLJT7-0007W8-QV for qemu-devel@nongnu.org; Tue, 01 Nov 2011 14:53:55 -0400 Received: from fmmailgate04.web.de ([217.72.192.242]:33420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLJT7-0007Va-CK for qemu-devel@nongnu.org; Tue, 01 Nov 2011 14:53:53 -0400 Received: from moweb001.kundenserver.de (moweb001.kundenserver.de [172.19.20.114]) by fmmailgate04.web.de (Postfix) with ESMTP id BBC236E58C7C for ; Tue, 1 Nov 2011 19:53:51 +0100 (CET) Message-ID: <4EB03FE9.7090007@web.de> Date: Tue, 01 Nov 2011 19:52:25 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1320088682-12958-1-git-send-email-andreas.faerber@web.de> <1320088682-12958-3-git-send-email-andreas.faerber@web.de> <47C91597-B6B1-4351-9DC3-30E405EC480B@sunshineco.com> <4EB0202E.50701@web.de> <20B88770-C260-4A2F-8E85-B84493675F10@sunshineco.com> In-Reply-To: <20B88770-C260-4A2F-8E85-B84493675F10@sunshineco.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Sunshine Cc: Peter Maydell , Juan Pineda , qemu-devel@nongnu.org Am 01.11.2011 19:47, schrieb Eric Sunshine: > On Nov 1, 2011, at 12:37 PM, Andreas F=E4rber wrote: >> Am 01.11.2011 09:09, schrieb Eric Sunshine: >>> Perhaps the following alternative solution would be more palatable? I= t's >>> still tremendously ugly, but is localized to cocoa.m, thus less >>> intrusive. >>> >>> -- >8 -- >>> Subject: [PATCH] softfloat: Avoid uint16 type conflict on Darwin >>> >>> cocoa.m includes indirectly via . >>> cssmconfig.h defines type uint16 which unfortunately conflicts with t= he >>> definition in qemu's softfloat.h, thus resulting in compilation failu= re. >>> To work around the problem, #define _UINT16, which informs cssmconfig= .h >>> that uint16 is already defined and that it should not apply its own >>> definition. >> >> Thanks for the suggestion! _UINT16 is an interesting suggestion, howev= er >> softfloat's uint16 is not uint16_t but int, so I'd rather not do it th= at >> way around. >> >> (I had also decided against the AIX path of never defining uint16 and >> always using system definitions, since that wouldn't work outside Coco= a >> code.) >> >> Do you have any thoughts about the include path issue? If we could kee= p >> QEMU code from getting into #import then we could >> redefine the system type instead, in cocoa.m. >=20 > Is the intention to trust uint16 from over the > one softfloat.h? If so, shouldn't we be taking as many type definitions > from as we can rather than just this one? (I'm > not recommending it; just trying to understand the goal.) Short-term goal: make Darwin build 1.0 without breaking others Long-term goal: not use uint16 etc. in QEMU at all Don't see what you mean with "taking as many type definitions". After uint16 I get no further conflicts for --enable-system --disable-user, so what is there to take? Andreas