From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38124) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLM5r-0007EQ-8s for qemu-devel@nongnu.org; Tue, 01 Nov 2011 17:42:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLM5p-0007Wo-Eo for qemu-devel@nongnu.org; Tue, 01 Nov 2011 17:42:03 -0400 Message-ID: <4EB067A2.70203@codemonkey.ws> Date: Tue, 01 Nov 2011 16:41:54 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1320006193-15219-1-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On 11/01/2011 04:05 PM, Blue Swirl wrote: > Thanks, pulled and reverted libfdt patch. Er, this broke the build: CC ppc64-softmmu/spapr_pci.o /home/anthony/git/qemu/hw/spapr_pci.c: In function ‘find_dev’: /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct ChildrenHead’ has no member named ‘lh_first’ /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct ’ has no member named ‘le_next’ /home/anthony/git/qemu/hw/spapr_pci.c: In function ‘spapr_populate_pci_devices’: /home/anthony/git/qemu/hw/spapr_pci.c:400:5: error: ‘struct ChildrenHead’ has no member named ‘lh_first’ /home/anthony/git/qemu/hw/spapr_pci.c:400:5: error: ‘struct ’ has no member named ‘le_next’ make[1]: *** [spapr_pci.o] Error 1 make: *** [subdir-ppc64-softmmu] Error 2 This is from commit: commit 3384f95c59e5db381cf3e605c8acec71baf0e6b8 Author: David Gibson Date: Sun Oct 30 17:16:46 2011 +0000 pseries: Add partial support for PCI And specifically: QLIST_FOREACH(qdev, &phb->host_state.bus->qbus.children, sibling) { PCIDevice *dev = (PCIDevice *)qdev; if (dev->devfn == devfn) { return dev; } } QBus::children is a QTAILQ, not a QLIST. Was this code tested at all? Regards, Anthony Liguori > > On Sun, Oct 30, 2011 at 20:22, Alexander Graf wrote: >> Hi Blue, >> >> This is my current patch queue for ppc. Please pull. >> >> Alex >> >> >> The following changes since commit 375847a6c0330e3de0fd1589eeb5a364692b791e: >> Max Filippov (1): >> MAINTAINERS: update wiki URL and machine names for target-xtensa >> >> are available in the git repository at: >> >> git://repo.or.cz/qemu/agraf.git ppc-next >> >> Alexander Graf (4): >> PPC: Bump qemu-system-ppc to 64-bit physical address space >> PPC: Disable non-440 CPUs for ppcemb target >> PPC: Fail configure when libfdt is not available >> KVM: PPC: Override host vmx/vsx/dfp only when information known >> >> David Gibson (15): >> pseries: Support SMT systems for KVM Book3S-HV >> pseries: Allow KVM Book3S-HV on PPC970 CPUS >> pseries: Use Book3S-HV TCE acceleration capabilities >> pseries: Update SLOF firmware image >> ppc: Generalize the kvmppc_get_clockfreq() function >> pseries: Add device tree properties for VMX/VSX and DFP under kvm >> pseries: Update SLOF firmware image >> ppc: Remove broken partial PVR matching >> ppc: First cut implementation of -cpu host >> ppc: Add cpu defs for POWER7 revisions 2.1 and 2.3 >> pseries: Under kvm use guest cpu = host cpu by default >> ppc: Avoid decrementer related kvm exits >> pseries: Correct vmx/dfp handling in both KVM and TCG cases >> ppc: Fix up usermode only builds >> pseries: Allow writes to KVM accelerated TCE table >> >> Fabien Chouteau (1): >> Set an invalid-bits mask for each SPE instructions >> >> Liu Yu-B13201 (2): >> ppc/e500_pci: Fix code style >> ppc/e500_pci: Fix an array overflow issue >> >> configure | 13 +- >> hw/ppc.c | 6 + >> hw/ppce500_pci.c | 82 ++++++-- >> hw/spapr.c | 99 +++++++-- >> hw/spapr_vio.c | 8 +- >> hw/spapr_vio.h | 1 + >> pc-bios/README | 2 +- >> pc-bios/slof.bin | Bin 579072 -> 738744 bytes >> roms/SLOF | 2 +- >> target-ppc/cpu.h | 23 ++- >> target-ppc/helper.c | 11 + >> target-ppc/kvm.c | 197 ++++++++++++++++- >> target-ppc/kvm_ppc.h | 50 +++++ >> target-ppc/translate.c | 500 +++++++++++++++++++++++-------------------- >> target-ppc/translate_init.c | 90 ++++---- >> 15 files changed, 755 insertions(+), 329 deletions(-) >> >