From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38738)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLMid-0005bG-Lb
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:22:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLMic-0000j2-A7
	for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:22:07 -0400
Message-ID: <4EB0710A.6000607@codemonkey.ws>
Date: Tue, 01 Nov 2011 17:22:02 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320172375-28019-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1320172375-28019-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] configure: Suppress messages from
 pkg_config probe for check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On 11/01/2011 01:32 PM, Peter Maydell wrote:
> Suppress confusing messages from pkg_config when probing for
> 'check' by sending them to /dev/null as we do with other
> similar probes.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> We didn't notice this before because we only recently
> changed the default for whether configure probed for this.
> I think that makes this a regression we should fix for 1.0.
>
>   configure |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 28667fe..9661b0e 100755
> --- a/configure
> +++ b/configure
> @@ -1828,7 +1828,7 @@ if test "$check_utests" != "no" ; then
>   #include<check.h>
>   int main(void) { suite_create("qemu test"); return 0; }
>   EOF
> -  check_libs=`$pkg_config --libs check`
> +  check_libs=`$pkg_config --libs check 2>/dev/null`
>     if compile_prog "" $check_libs ; then
>       check_utests=yes
>       libs_tools="$check_libs $libs_tools"