From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57523)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hkran@vnet.linux.ibm.com>) id 1RLXIW-0007Hu-1g
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 05:39:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hkran@vnet.linux.ibm.com>) id 1RLXIU-0001wt-7T
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 05:39:52 -0400
Received: from e28smtp01.in.ibm.com ([122.248.162.1]:59205)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hkran@vnet.linux.ibm.com>) id 1RLXIT-0001vx-09
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 05:39:49 -0400
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp01.in.ibm.com (8.14.4/8.13.1) with ESMTP id pA29dh0R022370
	for <qemu-devel@nongnu.org>; Wed, 2 Nov 2011 15:09:43 +0530
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pA29dfpa3616952
	for <qemu-devel@nongnu.org>; Wed, 2 Nov 2011 15:09:42 +0530
Received: from d28av02.in.ibm.com (loopback [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pA29df6E021953
	for <qemu-devel@nongnu.org>; Wed, 2 Nov 2011 20:39:41 +1100
Message-ID: <4EB10FAA.3090304@vnet.linux.ibm.com>
Date: Wed, 02 Nov 2011 17:38:50 +0800
From: hkran <hkran@vnet.linux.ibm.com>
MIME-Version: 1.0
References: <1320159390-29797-1-git-send-email-kraxel@redhat.com>
	<1320159390-29797-2-git-send-email-kraxel@redhat.com>
In-Reply-To: <1320159390-29797-2-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/3] usb-hub: wakeup on attach
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 11/01/2011 10:56 PM, Gerd Hoffmann wrote:
> When attaching a new device we must send a wakeup request to the root
> hub, otherwise the guest will not notice the new device in case the
> usb hub is suspended.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>
> ---
>   hw/usb-hub.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/usb-hub.c b/hw/usb-hub.c
> index 09c6516..7b47079 100644
> --- a/hw/usb-hub.c
> +++ b/hw/usb-hub.c
> @@ -163,6 +163,7 @@ static void usb_hub_attach(USBPort *port1)
>       } else {
>           port->wPortStatus&= ~PORT_STAT_LOW_SPEED;
>       }
> +    usb_wakeup(&s->dev);
>   }
>
>   static void usb_hub_detach(USBPort *port1)
pulled, In what cases, the usb hub will be suspended? and how to tell it 
happened? thanks.