From: Kevin Wolf <kwolf@redhat.com>
To: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Cc: zwu.kernel@gmail.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2] qed: adjust the way to get nb_sectors
Date: Wed, 02 Nov 2011 12:13:23 +0100 [thread overview]
Message-ID: <4EB125D3.9000000@redhat.com> (raw)
In-Reply-To: <1320134672-14310-1-git-send-email-wuzhy@linux.vnet.ibm.com>
Am 01.11.2011 09:04, schrieb Zhi Yong Wu:
> This patch is only to refactor some lines of codes to get better and more robust codes.
>
> As you have seen, in qed_read_table_cb() it's nice to
> use qiov->size because that function doesn't obviously use a single
> struct iovec.
>
> In other two functions, if qiov use more than one struct iovec, the existing way will get wrong nb_sectors.
> To make the code more robust, it will be nicer to refactor the existing way as below.
>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2011-11-02 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 8:04 [Qemu-devel] [PATCH v2] qed: adjust the way to get nb_sectors Zhi Yong Wu
2011-11-01 9:10 ` Stefan Hajnoczi
2011-11-02 11:13 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB125D3.9000000@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).