From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36561)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLaMJ-0005qX-10
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 08:55:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLaMD-0002qU-Sn
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 08:55:58 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:58953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLaMD-0002qJ-QG
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 08:55:53 -0400
Received: by ggnr5 with SMTP id r5so108921ggn.4
	for <qemu-devel@nongnu.org>; Wed, 02 Nov 2011 05:55:53 -0700 (PDT)
Message-ID: <4EB13DD6.1070302@codemonkey.ws>
Date: Wed, 02 Nov 2011 07:55:50 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320234974-15318-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1320234974-15318-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] intel-hda: fix stream search
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: marcandre.lureau@gmail.com, qemu-devel@nongnu.org

On 11/02/2011 06:56 AM, Gerd Hoffmann wrote:
> commit ba43d28916c4f51c19bd7366089155ce81bee058 introduces a bug:
> The stream-not-found case doesn't error out any more, instead the
> code silently uses the first stream.  Fix it.
>
> Signed-off-by: Gerd Hoffmann<kraxel@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/intel-hda.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/intel-hda.c b/hw/intel-hda.c
> index 675b659..b7ec36d 100644
> --- a/hw/intel-hda.c
> +++ b/hw/intel-hda.c
> @@ -401,7 +401,7 @@ static bool intel_hda_xfer(HDACodecDevice *dev, uint32_t stnr, bool output,
>               break;
>           }
>       }
> -    if (st == NULL) {
> +    if (s == 4) {
>           return false;
>       }
>       if (st->bpl == NULL) {