From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLeTB-0001Io-9W for qemu-devel@nongnu.org; Wed, 02 Nov 2011 13:19:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLeTA-00044c-1J for qemu-devel@nongnu.org; Wed, 02 Nov 2011 13:19:21 -0400 Received: from mail-gy0-f173.google.com ([209.85.160.173]:53474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLeT9-00044T-V9 for qemu-devel@nongnu.org; Wed, 02 Nov 2011 13:19:20 -0400 Received: by gya6 with SMTP id 6so409829gya.4 for ; Wed, 02 Nov 2011 10:19:19 -0700 (PDT) Message-ID: <4EB17B92.6020606@codemonkey.ws> Date: Wed, 02 Nov 2011 12:19:14 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1320041218-30487-1-git-send-email-david@gibson.dropbear.id.au> <1320041218-30487-6-git-send-email-david@gibson.dropbear.id.au> <4EAED0A6.4030808@weilnetz.de> <4EB0557C.70408@redhat.com> <20111102074020.GC5613@redhat.com> <4EB18467.1040801@suse.de> In-Reply-To: <4EB18467.1040801@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: joerg.roedel@amd.com, "Michael S. Tsirkin" , Stefan Weil , qemu-devel@nongnu.org, avi@redhat.com, eduard.munteanu@linux360.ro, David Gibson , rth@twiddle.net On 11/02/2011 12:56 PM, Alexander Graf wrote: > Michael S. Tsirkin wrote: >> On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: >> >> What does it get us, applying it before freeze? >> It's an api change without new functionality. >> Seems better on -next branch. >> > > It gets us that downstreams can convert to the API for 1.0. It just > feels a lot more right to change APIs for a 1.0 release than a 1.1 release. > > Also, it gives it more exposure and if anyone is inclined to have a > small patch to add IOMMU support for a specific platform downstream, > they can do so. > > Overall, I think it's a good idea to pull it in for 1.0. It certainly > makes David's life easier :). Since we also have PCI support in -M > pseries now we could even declare the non-usage of an IOMMU there as a > bug and fix it for 1.0.1. I was in violent agreement up until this last sentence ;-) Having new bidirectional memory APIs is a really big positive infrastructure change for us. It's been something we've needed for a long time. Regards, Anthony Liguori