From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:39080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLecR-0004JA-Uw for qemu-devel@nongnu.org; Wed, 02 Nov 2011 13:28:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLecQ-0005dy-Hw for qemu-devel@nongnu.org; Wed, 02 Nov 2011 13:28:55 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44499 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLecQ-0005dQ-4C for qemu-devel@nongnu.org; Wed, 02 Nov 2011 13:28:54 -0400 Message-ID: <4EB17DD1.7060600@suse.de> Date: Wed, 02 Nov 2011 18:28:49 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1320041218-30487-1-git-send-email-david@gibson.dropbear.id.au> <1320041218-30487-6-git-send-email-david@gibson.dropbear.id.au> <4EAED0A6.4030808@weilnetz.de> <4EB0557C.70408@redhat.com> <20111102074020.GC5613@redhat.com> <4EB18467.1040801@suse.de> <4EB17B92.6020606@codemonkey.ws> In-Reply-To: <4EB17B92.6020606@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: joerg.roedel@amd.com, "Michael S. Tsirkin" , Stefan Weil , qemu-devel@nongnu.org, avi@redhat.com, eduard.munteanu@linux360.ro, David Gibson , rth@twiddle.net Anthony Liguori wrote: > On 11/02/2011 12:56 PM, Alexander Graf wrote: >> Michael S. Tsirkin wrote: >>> On Tue, Nov 01, 2011 at 03:24:28PM -0500, Anthony Liguori wrote: >>> >>> What does it get us, applying it before freeze? >>> It's an api change without new functionality. >>> Seems better on -next branch. >>> >> >> It gets us that downstreams can convert to the API for 1.0. It just >> feels a lot more right to change APIs for a 1.0 release than a 1.1 >> release. >> >> Also, it gives it more exposure and if anyone is inclined to have a >> small patch to add IOMMU support for a specific platform downstream, >> they can do so. >> >> Overall, I think it's a good idea to pull it in for 1.0. It certainly >> makes David's life easier :). Since we also have PCI support in -M >> pseries now we could even declare the non-usage of an IOMMU there as a >> bug and fix it for 1.0.1. > > I was in violent agreement up until this last sentence ;-) Heh :). Well, I'm just saying that if the patch ends up being trivial and really really useful and necessary for users, we at least have the chance now. Alex