From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:59289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLh9c-0004IT-PH
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 16:11:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RLh9b-0000Vp-No
	for qemu-devel@nongnu.org; Wed, 02 Nov 2011 16:11:20 -0400
Message-ID: <4EB1A3E0.4090502@codemonkey.ws>
Date: Wed, 02 Nov 2011 15:11:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320006193-15219-1-git-send-email-agraf@suse.de>	<CAAu8pHtKRi+fu0KL4CtYrJ5uP4OrqPZYjirKTpT90cs-Dh4eCw@mail.gmail.com>	<4EB067A2.70203@codemonkey.ws>
	<CAAu8pHsuYvVUJ=xvK2PfeENr9u1NS_WOiO21MUfd9-6B=cLpQA@mail.gmail.com>
In-Reply-To: <CAAu8pHsuYvVUJ=xvK2PfeENr9u1NS_WOiO21MUfd9-6B=cLpQA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 00/22] ppc patch queue 2011-10-30
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org

On 11/02/2011 02:59 PM, Blue Swirl wrote:
> On Tue, Nov 1, 2011 at 21:41, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>> On 11/01/2011 04:05 PM, Blue Swirl wrote:
>>>
>>> Thanks, pulled and reverted libfdt patch.
>>
>> Er, this broke the build:
>>
>>   CC    ppc64-softmmu/spapr_pci.o
>> /home/anthony/git/qemu/hw/spapr_pci.c: In function ‘find_dev’:
>> /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct ChildrenHead’ has
>> no member named ‘lh_first’
>> /home/anthony/git/qemu/hw/spapr_pci.c:54:9: error: ‘struct<anonymous>’ has
>> no member named ‘le_next’
>> /home/anthony/git/qemu/hw/spapr_pci.c: In function
>> ‘spapr_populate_pci_devices’:
>> /home/anthony/git/qemu/hw/spapr_pci.c:400:5: error: ‘struct ChildrenHead’
>> has no member named ‘lh_first’
>> /home/anthony/git/qemu/hw/spapr_pci.c:400:5: error: ‘struct<anonymous>’ has
>> no member named ‘le_next’
>> make[1]: *** [spapr_pci.o] Error 1
>> make: *** [subdir-ppc64-softmmu] Error 2
>>
>> This is from commit:
>>
>> commit 3384f95c59e5db381cf3e605c8acec71baf0e6b8
>> Author: David Gibson<david@gibson.dropbear.id.au>
>> Date:   Sun Oct 30 17:16:46 2011 +0000
>>
>>     pseries: Add partial support for PCI
>>
>> And specifically:
>>
>>         QLIST_FOREACH(qdev,&phb->host_state.bus->qbus.children, sibling) {
>>             PCIDevice *dev = (PCIDevice *)qdev;
>>             if (dev->devfn == devfn) {
>>                 return dev;
>>             }
>>         }
>>
>> QBus::children is a QTAILQ, not a QLIST.
>>
>> Was this code tested at all?
>
> I built it and ran a quick test for PPC.
> 7f7623662781fa152c5aa39fd63a2e8766516a2c still builds fine here.
> Though I don't have libfdt and no test for pseries.

Yeah, libfdt isn't packaged widely still so it's understandable.  We run into 
this a lot.

Pulling it in as a submodule is probably a good idea.

Regards,

Anthony Liguori