From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:58099)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RLyI5-0005Mv-Jk
	for qemu-devel@nongnu.org; Thu, 03 Nov 2011 10:29:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RLyI4-0001cS-GO
	for qemu-devel@nongnu.org; Thu, 03 Nov 2011 10:29:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15247)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1RLyI4-0001cI-9O
	for qemu-devel@nongnu.org; Thu, 03 Nov 2011 10:29:12 -0400
Message-ID: <4EB2A5F1.5080407@redhat.com>
Date: Thu, 03 Nov 2011 15:32:17 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1318866452-30026-1-git-send-email-stefanha@linux.vnet.ibm.com>
	<1318866452-30026-7-git-send-email-stefanha@linux.vnet.ibm.com>
In-Reply-To: <1318866452-30026-7-git-send-email-stefanha@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC 6/6] block: add -drive copy-on-read=on|off
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org

Am 17.10.2011 17:47, schrieb Stefan Hajnoczi:
> This patch adds the -drive copy-on-read=on|off command-line option:
> 
>   copy-on-read=on|off
>   copy-on-read is "on" or "off" and enables whether to copy read backing
>   file sectors into the image file.  Copy-on-read avoids accessing the
>   same backing file sectors repeatedly and is useful when the backing
>   file is over a slow network.  By default copy-on-read is off.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
>  blockdev.c      |    6 ++++++
>  hmp-commands.hx |    5 +++--
>  qemu-config.c   |    4 ++++
>  qemu-options.hx |    9 ++++++++-
>  4 files changed, 21 insertions(+), 3 deletions(-)
> 
> diff --git a/blockdev.c b/blockdev.c
> index 0827bf7..1dd0f23 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -236,6 +236,7 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi)
>      const char *devaddr;
>      DriveInfo *dinfo;
>      int snapshot = 0;
> +    int copy_on_read;

Another s/int/bool/ :-)

Kevin