From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:38720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLyg1-0001sH-96 for qemu-devel@nongnu.org; Thu, 03 Nov 2011 10:53:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLyg0-00068Z-5l for qemu-devel@nongnu.org; Thu, 03 Nov 2011 10:53:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLyfz-00068R-TD for qemu-devel@nongnu.org; Thu, 03 Nov 2011 10:53:56 -0400 Message-ID: <4EB2AAF8.1000209@redhat.com> Date: Thu, 03 Nov 2011 16:53:44 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1317360376-12090-1-git-send-email-david@gibson.dropbear.id.au> <4EB07096.4070806@us.ibm.com> <4EB26EA5.4060606@redhat.com> <4EB291F4.8070503@us.ibm.com> <4EB29381.9060707@redhat.com> <4EB2993C.9000902@codemonkey.ws> <4EB29B00.10907@redhat.com> <4EB29BEB.4070603@codemonkey.ws> <20111103143129.GA20860@redhat.com> <4EB2A747.9040909@codemonkey.ws> In-Reply-To: <4EB2A747.9040909@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] virtio: Add PCI memory BAR in addition to PIO BAR List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: kvm@vger.kernel.org, "Michael S. Tsirkin" , rusty@rustcorp.com.au, qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org, Pekka Enberg , David Gibson On 11/03/2011 04:37 PM, Anthony Liguori wrote: > >>>>>> 2. Proposed spec patch, kernel change, qemu change >>>>>> 3. Buy-ins from spec maintainer, kernel driver maintainer, qemu >>>>>> device >>>>>> maintainer (only regarding the ABI, not the code) >>>>> >>>>> I don't think this is how it's working today. I would be happy >>>>> with a >>>>> flow like this. >>>> >>>> If Michael and Rusty agree, we can adopt it immediately. >>>> >> >> If I understand the proposal, what is suggested is that >> all of spec, kvm and virtio patches are posted on list and >> acked before merging any one of them? >> >> Sure, this makes sense. > > Well, what's needed before the spec is changed is an interesting > question, but I think the main thing is, don't commit any virtio ABI > changes to vhost, QEMU, NKT, or the kernel until the spec for the > change has been committed. > > It would be nice to have a working implementation before committing a > spec change. Even nicer would be to have Acked-by's a maintainer in > each area affected. > Those are steps 2 and 3 of the proposed process. -- error compiling committee.c: too many arguments to function