Re: [Qemu-devel] [PATCH 1.0] add sgabios blob and submodule

[Anthony Liguori <anthony@codemonkey.ws>]

On 11/03/2011 08:39 PM, Zhi Yong Wu wrote:
> On Thu, Nov 3, 2011 at 10:14 PM, Paolo Bonzini<pbonzini@redhat.com>  wrote:
>> The rom was not added together with the sgabios device and is
>> not installed.
>>
>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>> ---
>>         The sgabios.git mirror repository can be fetched from
>>         http://people.redhat.com/pbonzini/sgabios-git.tgz
>>
>>   .gitmodules         |    3 +++
>>   Makefile            |    2 +-
>>   pc-bios/README      |    6 ++++++
>>   pc-bios/sgabios.bin |  Bin 0 ->  4096 bytes
>>   roms/sgabios        |    1 +
> Sorry, what are sgabios and sgabios.bin separately? What is the relationship?

The way git does submodules is that it stores a file in the tree that contains 
the commit hash of the submodule along with metadata indicating that its a 
submodule.  So in a git diff, you see a commit hash change, but when you check 
out or commit, it's really a directory that contains an external git tree.

We use submodules for all of the different firmware blobs that you need to run a 
guest.  You can look in roms/* for the full list.

We also include the binary blobs in the tree because they often require special 
build tools (or at least, target specific cross compilers).  That means that 
most people don't have the necessary tools available to build those blobs.

Regards,

Anthony Liguori

>
>>   5 files changed, 11 insertions(+), 1 deletions(-)
>>   create mode 100755 pc-bios/sgabios.bin
>>   create mode 160000 roms/sgabios
>>
>> diff --git a/.gitmodules b/.gitmodules
>> index 2a43dbc..eca876f 100644
>> --- a/.gitmodules
>> +++ b/.gitmodules
>> @@ -16,3 +16,6 @@
>>   [submodule "roms/qemu-palcode"]
>>         path = roms/qemu-palcode
>>         url = git://repo.or.cz/qemu-palcode.git
>> +[submodule "roms/sgabios"]
>> +       path = roms/sgabios
>> +       url = git://git.qemu.org/sgabios.git
>> diff --git a/Makefile b/Makefile
>> index 4f6eaa4..168093c 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -253,7 +253,7 @@ ar      de     en-us  fi  fr-be  hr     it  lv  nl         pl  ru     th \
>>   common  de-ch  es     fo  fr-ca  hu     ja  mk  nl-be      pt  sl     tr
>>
>>   ifdef INSTALL_BLOBS
>> -BLOBS=bios.bin vgabios.bin vgabios-cirrus.bin \
>> +BLOBS=bios.bin sgabios.bin vgabios.bin vgabios-cirrus.bin \
>>   vgabios-stdvga.bin vgabios-vmware.bin vgabios-qxl.bin \
>>   ppc_rom.bin openbios-sparc32 openbios-sparc64 openbios-ppc \
>>   pxe-e1000.rom pxe-eepro100.rom pxe-ne2k_pci.rom \
>> diff --git a/pc-bios/README b/pc-bios/README
>> index 0668559..1cebbbc 100644
>> --- a/pc-bios/README
>> +++ b/pc-bios/README
>> @@ -19,6 +19,12 @@
>>    https://github.com/dgibson/SLOF, and the image currently in qemu is
>>    built from git tag qemu-slof-20111013.
>>
>> +- sgabios (the Serial Graphics Adapter option ROM) provides a means for
>> +  legacy x86 software to communicate with an attached serial console as
>> +  if a video card were attached.  The master sources reside in a subversion
>> +  repository at http://sgabios.googlecode.com/svn/trunk.  A git mirror is
>> +  available at git://git.qemu.org/sgabios.git.
>> +
>>   - The PXE roms come from the iPXE project. Built with BANNER_TIME 0.
>>    Sources available at http://ipxe.org.  Vendor:Device ID ->  ROM mapping:
>>
>> diff --git a/pc-bios/sgabios.bin b/pc-bios/sgabios.bin
>> new file mode 100755
>> index 0000000000000000000000000000000000000000..c3da4c3d0a34e4eca9b0cda38d0538b332f7b09e
>> GIT binary patch
>> literal 4096
>> zcmeHJeRNah8Gmw<CMA}H3E~Hu1gWw1<C3&cp`^7R6etvvCcx5Msf5x%J8fB-%VdXB
>> z(goPP4Wd)$$L3rSH#>(K=NZ!#YiO_$Hpho3C>|*k=364AM}*OQ+`H$d;Erd1?wtL_
>> zdrscx_dM_O{NCq%?)%)_<*#K9x2T8LsLwZz!svOLz$lClLt13p+N?4Pp<PnTVJXP{
>> z{vin~r3n_cwXJ=mDc?}j+DL<=$=mFH#IVroUcaunvE5Ly#=YLx<TaShGfhP^&1P^c
>> ztf;K9It<x0YqAYF>sPn6{<OKZxqPGhM=dnl-sElH*iL(!)~s{;=*G53?=vi0#~L1N
>> z+h8yh8O%i`MMWjE&4%U6stkoDB(vQ%jWN$FoL%gl#^5ZWMbnt#R#?{LeYC^?)s^!r
>> zP@KOsf(J`abH9R7@%saGCfacG^t&~;X5VAH(|p_Q+R6GUQ)m95;Ff$@-n5@@pZl|(
>> zEnBy7IbA{i@uI9*vu~p0iVUSHbAtNSd*7Zo>(7CgLT_|Gwe#g&&%N@y-~Z{Y=U;g8
>> z>EAx{?3=%M{g=D%kmB#V#y>;iFGT)H-|_$IkH7wd2FlAf<mTqm*G6ucWz%$<qhM3R
>> zhB8ZSLBobBw#kj7v8k!4xw*NbqS{^2*4D<d8?DP5YwK+ucXJ!t`k=e*fr5g<S<@|L
>> zGiJ=#gd;Cc`bndpU{gU_NrM6$<MzC~83mg*6}VTgUEkEs`b?&__U4UE4W)UQ!KQ*z
>> z%x6PuVXgrblv0)<S6!8-A2&{`bjp@;y;!UPmFJzlzrOyZSu|?*Ox$-mGx?3@&A>&4
>> z(K9!L)zW+!O&LAG>I~YmE0<E~-4Tq`c3+R>2WU@_&ZX!e`URplc_v)&RTzVJbtb^y
>> zKF2cAH_MXAswSND<u8dDJnw=G!rDTQ&13hNk9v5bHSwcsIF-lcacWIfM*glql)_oN
>> zQ`+do@f>$*AVA7@giGOh@BQ&zsL_)_w&O$}D71UB{0iB=(`uU6m?*QDyz~kk)R`zx
>> zRE2jGq6-zEh%Uq{j&#3~62G1{rfZ@mh`wT@r?XUYW%G@}l}aPm2{P@T$dN(PozWQu
>> zN)|Qpw^ZR_WGrPqnT|5@E0yUo@aF~=XyCs&8^7bMC$5Z?#Ji+j(HQ|5f8xmCI4ggc
>> z|7=M8&70D3=Vth(rkOjVf*dP!-OAq4c@Zc&4>LV-k(Q&tSedaagIl1H5}3y@6)?|g
>> zgL#bE+yNGbsRWC)4uQF_14<dD3QDbZ1m>a+C}WuUP-b-?Fwg3M2N<RrC-ZEC)@4x6
>> znD6g^a_e%aV9awmpu)NWDjD<K4yd&L5UQ9$QwLO8oiLv%#GU3_>tQQXh^$+!F4)Et
>> zBB7nZJsk|%mRRS*65MPdgRTpiMPOxc-O4P0Mb-*fggM)+m0-hUYZ%<Vjw$YdrPeA~
>> ziur=g?x2HHbErVS%oH98^i!dyN79B~8E_{?xT}@pYM@^pnvCnRko>xV3du$omosuL
>> zKI3bP7_mFZMbT&Mk@@aUo4@YyvlqC2okrgavg7*f&D?(Ouw^q#g)+B>8CRsveBkT_
>> z@}YQotUj{bQD^hCfcXG_j{H;fm2nF|*jMczQ}{B-ry@Jr`>mWmM|a&@m3h`To$i`h
>> zm3hH;^PE;-<<+s#ah<&y`@$6F&+!Wsf&B_+J+m@mv)5q`Q@H)_j*7$~_83l&af9jH
>> zM(Qzn2d38J_bIbC_jb#UTMX@rUOy(vL@X+w){^PF$)fhDu&d<cm>3}iDe{pRQ<8g9
>> z<V(>`F3HGw$}*8vWFGb9XNG+_#E~SAix{fI&@2p{grSp!{+I?m)WX4-QW%I)rlWMp
>> z)L!ta=q?n(LAs=PZ(2hk{DZVnI_w&LY8L2S5!;I7?k!=gK(QFR(%?+%q(eLtm#_mD
>> z$&ba|T!eVx%(o4UWILwjBiz+vYA(tRN|9M65*IR)J{5Nr;YEQvfr1E<Z)hSpC4|)E
>> zb3sz3k)uM0As<N!K1FVnyd{R_k@p1dFnLu(qrJ0VCL?FW&?3?!VD0=vn{`T?!`@P^
>> z(&&vPIuH0P{)CFnz`$4m_eHOP;s&!-$GLuPFiaH3xq;4pT@KkPv91-uXBFD#!;ev+
>> zsiZ~>JxZ1fF2=|qiBqMIycl046@k2wvP@&;WGEHX-3h!Z5TOEzGOxT>2Rs_2cg*mL
>> zv0>-fD*jyHgGqQXGW<yeTb(Z8$47<&L#m)wPtVolP^?K8Y=9jNl&7;y3AHt~R(48f
>> znHr`l*{lKO%>eic!!tdpciTyR%5>Is$UU4fX0sE0%BRBnEGI3Z%Q-ydDjqnU+9(8d
>> zS&;Mbm6JLDx^gP>D67J9KAAF|^ougYYO*C|68#C$r}ifVHY=1#+EX~SN*)Qx!$4N2
>> zy+u|{{6eULI4}TT+;Z}aF#h!M89Clok!J;l1XB^RLx`y)eH-dtAnQ|sG1&%rO)N$%
>> z5Fs=0&8XD#BRv$GMH+>z2axD+Dkdk#Q#~@Qp&Z}I5u22{c26{0b$C!=<0Jg7dS^uE
>> zKx0?gY9OaXMvpC#_BrJrQXL-hM{L1cgPK)<EunMNU3dIktVd6B8k{aSwuCu+h<qYp
>> zDYVPD7`kgfBGexueg83gfRx1bhp-(dk|$E3Lb5s;T1-|Z@knpu(alGP9~M{G$#WwA
>> zsmlUBt&KFNu;oGyGB@dJh}gEB!ZK_-CG9cc06WDms#q;qAQ9az5lu<P^6mUVGE;Qb
>> znJ!%U42}r<=n@S!S_a*P!Y7q{Uh+($Uie_n<qgO5PCNe%k%>r+yH3Bh>kBq=DM|j4
>> z3@sy(1TN8?Wmy1WRvy?-MOI-e*_ZR@f-5vD*FB`(a+Z}3&lLSh3gs@rpOm8<MyW(O
>> z3+*bFitX|zGf};a<_Re0pj4xrjZ%a1E|gl7eJCfREEb%u@Aky!=pKIY@;e7XY6xWu
>> zNR8&%nFF3(Lx3P30g*sC0<{Ee2rfv#i9id+s4@rp#<*RRE8%?DE@4{2<#1&J;z|kI
>> z;0eiYm#`DQlCTTNnK44g*+k!aKz@>FDaW#_-nRi+9QP?-3y2T1mrY@mPVYl~Hh8^s
>> z8pAqFCwE&+-damZyE<FTeesE!i^MKi=CLLIgxX7+L}``2wwlD%D6ZPsTWC(V7p@)J
>> zr=hvBUWln^Or0W>DU5r*I|-7PUeoBwOJnQ^S&--}2XZz}N)vrcft-w!S&6<@AV=dQ
>> zFL9lwzV8^2a2%7SyL;i~#V~-U1oCA(^cXomMtAQ8Zolw%&bS3QV;zuzIJp=fP}YEa
>> zK-mQMMU{<kOdeI%;<x*N(gUjPA4ZjH@hfguGazO677)Vp%X>k(>ojNV1){$~-oMg!
>> z5=d>F-f5z?4U+aa-nY&8Z$p~n<f*vyMfA7pAA|q1{QlSY4edq+ZdBm^RDlO;YDN9O
>> E0dGKec>n+a
>>
>> literal 0
>> HcmV?d00001
>>
>> diff --git a/roms/sgabios b/roms/sgabios
>> new file mode 160000
>> index 0000000..23d4749
>> --- /dev/null
>> +++ b/roms/sgabios
>> @@ -0,0 +1 @@
>> +Subproject commit 23d474943dcd55d0550a3d20b3d30e9040a4f15b
>> --
>> 1.7.6.4
>>
>>
>>
>
>
>