From: Paolo Bonzini <pbonzini@redhat.com>
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus
Date: Fri, 04 Nov 2011 08:43:54 +0100 [thread overview]
Message-ID: <4EB397BA.3010307@redhat.com> (raw)
In-Reply-To: <4EB351E6.3090807@cn.fujitsu.com>
On 11/04/2011 03:45 AM, Wen Congyang wrote:
> We disable vm_clock when pausing all vcpus, but we forget to
> reenable it when resuming all vcpus. It will cause that the
> guest can not be rebooted.
>
> Signed-off-by: Wen Congyang<wency@cn.fujitsu.com>
>
> ---
> cpus.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/cpus.c b/cpus.c
> index 6aff425..82530c4 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -891,6 +891,7 @@ void resume_all_vcpus(void)
> {
> CPUState *penv = first_cpu;
>
> + qemu_clock_enable(vm_clock, true);
> while (penv) {
> penv->stop = 0;
> penv->stopped = 0;
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
The code I have now works for TCG, but of course not for KVM. Thanks.
Paolo
next prev parent reply other threads:[~2011-11-04 7:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-04 2:45 [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus Wen Congyang
2011-11-04 2:48 ` Zhi Yong Wu
2011-11-04 6:26 ` Wen Congyang
2011-11-04 11:31 ` Zhi Yong Wu
2011-11-07 2:24 ` Zhi Yong Wu
2011-11-04 7:43 ` Paolo Bonzini [this message]
2011-11-08 17:24 ` Anthony Liguori
2011-11-09 16:22 ` Eduardo Habkost
2011-11-10 8:28 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB397BA.3010307@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).