From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMERW-0006J3-KQ for qemu-devel@nongnu.org; Fri, 04 Nov 2011 03:44:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RMERV-0004OO-Gj for qemu-devel@nongnu.org; Fri, 04 Nov 2011 03:44:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38373) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMERV-0004OG-7D for qemu-devel@nongnu.org; Fri, 04 Nov 2011 03:44:01 -0400 Message-ID: <4EB397BA.3010307@redhat.com> Date: Fri, 04 Nov 2011 08:43:54 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <4EB351E6.3090807@cn.fujitsu.com> In-Reply-To: <4EB351E6.3090807@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] reenable vm_clock when resuming all vcpus List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang Cc: qemu-devel On 11/04/2011 03:45 AM, Wen Congyang wrote: > We disable vm_clock when pausing all vcpus, but we forget to > reenable it when resuming all vcpus. It will cause that the > guest can not be rebooted. > > Signed-off-by: Wen Congyang > > --- > cpus.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/cpus.c b/cpus.c > index 6aff425..82530c4 100644 > --- a/cpus.c > +++ b/cpus.c > @@ -891,6 +891,7 @@ void resume_all_vcpus(void) > { > CPUState *penv = first_cpu; > > + qemu_clock_enable(vm_clock, true); > while (penv) { > penv->stop = 0; > penv->stopped = 0; Reviewed-by: Paolo Bonzini The code I have now works for TCG, but of course not for KVM. Thanks. Paolo