From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:37926)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHQw-0000Oc-Dw
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 06:55:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHQv-0002WI-0o
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 06:55:38 -0400
Received: from e23smtp04.au.ibm.com ([202.81.31.146]:60956)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHQu-0002VV-E7
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 06:55:36 -0400
Received: from /spool/local
	by e23smtp04.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <supriyak@linux.vnet.ibm.com>;
	Fri, 4 Nov 2011 10:44:07 +1000
Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138])
	by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pA4AtM1s2031688
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 21:55:25 +1100
Received: from d23av02.au.ibm.com (loopback [127.0.0.1])
	by d23av02.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pA4AtMiU000830
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 21:55:22 +1100
Message-ID: <4EB3C498.9040401@linux.vnet.ibm.com>
Date: Fri, 04 Nov 2011 16:25:20 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20111030103327.31685.17045.sendpatchset@skannery.in.ibm.com>
	<20111030103354.31685.6508.sendpatchset@skannery.in.ibm.com>
	<20111103115514.661760f0@doriath>
In-Reply-To: <20111103115514.661760f0@doriath>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v8 Patch 1/6]Qemu: Enhance "info block" to
 display host cache setting
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 11/03/2011 07:25 PM, Luiz Capitulino wrote:
> On Sun, 30 Oct 2011 16:03:54 +0530
> Supriya Kannery<supriyak@linux.vnet.ibm.com>  wrote:
>> +    if (qdict_haskey(bs_dict, "hostcache")) {
>> +        monitor_printf(mon, " hostcache=%d",
>> +                       qdict_get_bool(bs_dict, "hostcache"));
>> +    }
>
> This series needs to be rebased, as the info block command has been
> converted to the QAPI. Please, see the following commit for details:
> b202381800d81fbff9978abbdea95760dd363bb6.
>
> Also note that if you're adding new commands (I haven't reviewed the
> series) you should use the QAPI. A document on how to use it is coming soon.
>

yes, will rebase and use QAPI

>>
>>       if (qdict_haskey(bs_dict, "io-status")) {
>>           monitor_printf(mon, " io-status=%s", qdict_get_str(bs_dict, "io-status"));
>>       }