From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56384)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHYf-0001Vz-4i
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 07:03:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHYd-000422-R0
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 07:03:37 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:44864)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHYc-00041e-Sd
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 07:03:35 -0400
Received: from d28relay05.in.ibm.com (d28relay05.in.ibm.com [9.184.220.62])
	by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id pA4B3Ut1021647
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 16:33:30 +0530
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pA4B3TvE2756798
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 16:33:29 +0530
Received: from d28av05.in.ibm.com (loopback [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pA4B3S3E026845
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 22:03:28 +1100
Message-ID: <4EB3C680.7080308@linux.vnet.ibm.com>
Date: Fri, 04 Nov 2011 16:33:28 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20111030103327.31685.17045.sendpatchset@skannery.in.ibm.com>
	<20111030103429.31685.89126.sendpatchset@skannery.in.ibm.com>
	<4EB3B7AF.5000605@redhat.com>
In-Reply-To: <4EB3B7AF.5000605@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v8 Patch 3/6]Qemu: Cmd "block_set_hostcache" for
 dynamic cache change
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 11/04/2011 03:30 PM, Kevin Wolf wrote:
> Am 30.10.2011 11:34, schrieb Supriya Kannery:
>> +
>> +    if (bdrv_is_inserted(bs)) {
>> +        /* Reopen file with changed set of flags */
>> +        return bdrv_reopen(bs, bdrv_flags);
>> +    } else {
>> +        /* Save hostcache change for future use */
>> +        bs->open_flags = bdrv_flags;
>> +        return 0;
>> +    }
>
> Maybe the !bdrv_is_inserted() case should be handled in bdrv_reopen(). I
> think it would be the same for changing other flags.
>

I am yet to look at the conditions specific to other flags. So I can
move this check to bdrv_reopen when implementing one more flag I guess.

> Kevin
>