From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>,
qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely
Date: Fri, 04 Nov 2011 16:40:21 +0530 [thread overview]
Message-ID: <4EB3C81D.4080302@linux.vnet.ibm.com> (raw)
In-Reply-To: <4EB3B8CF.4060105@redhat.com>
On 11/04/2011 03:35 PM, Kevin Wolf wrote:
> Am 30.10.2011 11:35, schrieb Supriya Kannery:
>>
>> +struct BDRVReopenState {
>> + BlockDriverState *bs;
>> + int reopen_flags;
>> +
>> + /* For raw-posix */
>> + int reopen_fd;
>> +};
>
> I think I commented the same on the previous version: BDRVReopenState
> shouldn't contain any format specific fields. raw-posix must extend the
> struct like this and use container_of() to get it from a BDRVReopenState
> pointer:
>
> struct BDRVRawReopenState {
> BDRVReopenState common;
> int reopen_fd;
> };
>
I don't recall this was suggested in prev version or may be I missed to
notice..
ok, will have raw extending common BDRVReopenState struct.
> Kevin
>
next prev parent reply other threads:[~2011-11-04 11:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 10:33 [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor Supriya Kannery
2011-10-30 10:33 ` [Qemu-devel] [v8 Patch 1/6]Qemu: Enhance "info block" to display host cache setting Supriya Kannery
2011-11-03 13:55 ` Luiz Capitulino
2011-11-04 10:55 ` Supriya Kannery
2011-10-30 10:34 ` [Qemu-devel] [v8 Patch 2/6]Qemu: Error classes for file reopen and data sync failure Supriya Kannery
2011-10-30 10:34 ` [Qemu-devel] [v8 Patch 3/6]Qemu: Cmd "block_set_hostcache" for dynamic cache change Supriya Kannery
2011-11-04 10:00 ` Kevin Wolf
2011-11-04 11:03 ` Supriya Kannery
2011-10-30 10:34 ` [Qemu-devel] [v8 Patch 4/6]Qemu: Add commandline -drive option 'hostcache' Supriya Kannery
2011-10-30 10:35 ` [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images safely Supriya Kannery
2011-11-04 10:05 ` Kevin Wolf
2011-11-04 11:10 ` Supriya Kannery [this message]
2011-10-30 10:35 ` [Qemu-devel] [v8 Patch 6/6]Qemu: raw posix implementation of reopen functions Supriya Kannery
2011-11-04 10:19 ` Kevin Wolf
2011-11-04 2:29 ` [Qemu-devel] [v8 Patch 0/6]Qemu: Host pagecache setting from cmdline and monitor Zhi Yong Wu
2011-11-07 8:38 ` Supriya Kannery
2011-11-07 8:49 ` Zhi Yong Wu
2011-11-07 9:35 ` Supriya Kannery
2011-11-07 10:24 ` Zhi Yong Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB3C81D.4080302@linux.vnet.ibm.com \
--to=supriyak@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).