From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHfH-00034E-UQ
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 07:10:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHfG-0005IC-SD
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 07:10:27 -0400
Received: from e28smtp03.in.ibm.com ([122.248.162.3]:46165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <supriyak@linux.vnet.ibm.com>) id 1RMHfF-0005Ha-Oh
	for qemu-devel@nongnu.org; Fri, 04 Nov 2011 07:10:26 -0400
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by e28smtp03.in.ibm.com (8.14.4/8.13.1) with ESMTP id pA4BAMLN028088
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 16:40:22 +0530
Received: from d28av02.in.ibm.com (d28av02.in.ibm.com [9.184.220.64])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	pA4BAME24284670
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 16:40:22 +0530
Received: from d28av02.in.ibm.com (loopback [127.0.0.1])
	by d28av02.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id
	pA4BAMTZ030560
	for <qemu-devel@nongnu.org>; Fri, 4 Nov 2011 22:10:22 +1100
Message-ID: <4EB3C81D.4080302@linux.vnet.ibm.com>
Date: Fri, 04 Nov 2011 16:40:21 +0530
From: Supriya Kannery <supriyak@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <20111030103327.31685.17045.sendpatchset@skannery.in.ibm.com>
	<20111030103509.31685.87434.sendpatchset@skannery.in.ibm.com>
	<4EB3B8CF.4060105@redhat.com>
In-Reply-To: <4EB3B8CF.4060105@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v8 Patch 5/6]Qemu: Framework for reopening images
 safely
Reply-To: supriyak@linux.vnet.ibm.com
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Christoph Hellwig <hch@lst.de>

On 11/04/2011 03:35 PM, Kevin Wolf wrote:
> Am 30.10.2011 11:35, schrieb Supriya Kannery:
>>
>> +struct BDRVReopenState {
>> +    BlockDriverState *bs;
>> +    int reopen_flags;
>> +
>> +    /* For raw-posix */
>> +    int reopen_fd;
>> +};
>
> I think I commented the same on the previous version: BDRVReopenState
> shouldn't contain any format specific fields. raw-posix must extend the
> struct like this and use container_of() to get it from a BDRVReopenState
> pointer:
>
> struct BDRVRawReopenState {
>      BDRVReopenState common;
>      int reopen_fd;
> };
>

I don't recall this was suggested in prev version or may be I missed to 
notice..
ok, will have raw extending common BDRVReopenState struct.


> Kevin
>