From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37148) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMJn1-0003LF-Hq for qemu-devel@nongnu.org; Fri, 04 Nov 2011 09:26:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RMJmu-0002XV-8k for qemu-devel@nongnu.org; Fri, 04 Nov 2011 09:26:35 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49325 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RMJmu-0002XL-4B for qemu-devel@nongnu.org; Fri, 04 Nov 2011 09:26:28 -0400 Message-ID: <4EB3E7FF.4020908@suse.de> Date: Fri, 04 Nov 2011 14:26:23 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <9746334627355@192.168.2.69> <9745359965177@192.168.2.69> In-Reply-To: <9745359965177@192.168.2.69> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Do you have a use for a tester of virtio-scsi with CD drives ? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Schmitt Cc: kwolf@redhat.com, stefanha@gmail.com, qemu-devel@nongnu.org, pbonzini@redhat.com Hi Thomas, Am 03.11.2011 23:30, schrieb Thomas Schmitt: > I tried to activate DPRINTF in hw/scsi-generic.c by removing the "//" > before > #define DEBUG_SCSI >=20 > make yields: > .../hw/scsi-generic.c: In function 'scsi_send_command': > .../hw/scsi-generic.c:286: error: 'lun' undeclared (first use in this= function) > .../hw/scsi-generic.c:286: error: 'tag' undeclared (first use in this= function) We're about to release QEMU 1.0(-rc1) and you've just spotted a compilation issue... > So i had to change in scsi_send_command(): >=20 > - DPRINTF("Command: lun=3D%d tag=3D0x%x len %zd data=3D0x%02x", l= un, tag, > + DPRINTF("Command: len %zd data=3D0x%02x", You've solved this issue 50%! What's missing now is for you to put this fix into a self-contained patch (without the enabling of DEBUG_SCSI, etc.) and to submit it using the git-send-email command, so that your fix can be applied. :) http://wiki.qemu.org/Contribute/SubmitAPatch Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg