From: Avi Kivity <avi@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations
Date: Sun, 06 Nov 2011 16:27:21 +0200 [thread overview]
Message-ID: <4EB69949.4070503@redhat.com> (raw)
In-Reply-To: <1319109385-7927-5-git-send-email-pbonzini@redhat.com>
On 10/20/2011 01:16 PM, Paolo Bonzini wrote:
> This does the first part of the conversion to coroutines, by
> wrapping bdrv_read implementations to take the read side of the
> rwlock.
>
> Drivers that implement bdrv_read rather than bdrv_co_readv can
> then benefit from asynchronous operation (at least if the underlying
> protocol supports it, which is not the case for raw-win32), even
> though they still operate with a bounce buffer.
>
> raw-win32 does not need the lock, because it cannot yield.
> nbd also doesn't probably, but better be safe.
This patch (2914caa088e3fbbd) breaks autotest when a guest reboots after
install; instead of rebooting, the guest is stuck in the bootloader or
kernel.
This was discovered in qemu-kvm, but applies to plain qemu too. The
commit above is broken, it's parent is good.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-06 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 11:16 [Qemu-devel] [PATCH v2 0/7] finish coroutinization of drivers Paolo Bonzini
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 1/7] vmdk: fix return values of vmdk_parent_open Paolo Bonzini
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 2/7] vmdk: clean up open Paolo Bonzini
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 3/7] block: add a CoMutex to synchronous read drivers Paolo Bonzini
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations Paolo Bonzini
2011-11-06 14:27 ` Avi Kivity [this message]
2011-11-06 17:25 ` Paolo Bonzini
2011-11-06 17:29 ` Avi Kivity
2011-11-07 22:26 ` Avi Kivity
2011-11-07 23:12 ` Avi Kivity
2011-11-07 9:12 ` Kevin Wolf
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 5/7] block: take lock around bdrv_write implementations Paolo Bonzini
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 6/7] block: change flush to co_flush Paolo Bonzini
2011-10-20 11:16 ` [Qemu-devel] [PATCH v2 7/7] block: change discard to co_discard Paolo Bonzini
2011-10-21 9:42 ` [Qemu-devel] [PATCH v2 0/7] finish coroutinization of drivers Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB69949.4070503@redhat.com \
--to=avi@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).