From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RN6TX-00008t-FU for qemu-devel@nongnu.org; Sun, 06 Nov 2011 12:25:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RN6TW-00075T-IV for qemu-devel@nongnu.org; Sun, 06 Nov 2011 12:25:43 -0500 Received: from mail-ww0-f53.google.com ([74.125.82.53]:45055) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RN6TW-000758-E8 for qemu-devel@nongnu.org; Sun, 06 Nov 2011 12:25:42 -0500 Received: by wwg7 with SMTP id 7so5033757wwg.10 for ; Sun, 06 Nov 2011 09:25:41 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4EB6C312.2020402@redhat.com> Date: Sun, 06 Nov 2011 18:25:38 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1319109385-7927-1-git-send-email-pbonzini@redhat.com> <1319109385-7927-5-git-send-email-pbonzini@redhat.com> <4EB69949.4070503@redhat.com> In-Reply-To: <4EB69949.4070503@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Avi Kivity On 11/06/2011 03:27 PM, Avi Kivity wrote: > On 10/20/2011 01:16 PM, Paolo Bonzini wrote: >> This does the first part of the conversion to coroutines, by >> wrapping bdrv_read implementations to take the read side of the >> rwlock. >> >> Drivers that implement bdrv_read rather than bdrv_co_readv can >> then benefit from asynchronous operation (at least if the underlying >> protocol supports it, which is not the case for raw-win32), even >> though they still operate with a bounce buffer. >> >> raw-win32 does not need the lock, because it cannot yield. >> nbd also doesn't probably, but better be safe. > > This patch (2914caa088e3fbbd) breaks autotest when a guest reboots after > install; instead of rebooting, the guest is stuck in the bootloader or > kernel. Are any of these formats used by autotest? block/bochs.c | 13 ++++++++++++- block/cloop.c | 13 ++++++++++++- block/cow.c | 13 ++++++++++++- block/dmg.c | 13 ++++++++++++- block/nbd.c | 13 ++++++++++++- block/parallels.c | 13 ++++++++++++- block/vmdk.c | 13 ++++++++++++- block/vpc.c | 13 ++++++++++++- block/vvfat.c | 13 ++++++++++++- 9 files changed, 108 insertions(+), 9 deletions(-) Perhaps the failure is only reproduced 80-90% of the time and this screws up the bisection. Paolo