* [Qemu-devel] [PATCH] fix segfault on fd-migration starting
@ 2011-11-07 2:34 Wen Congyang
2011-11-07 11:22 ` Juan Quintela
0 siblings, 1 reply; 2+ messages in thread
From: Wen Congyang @ 2011-11-07 2:34 UTC (permalink / raw)
To: qemu-devel
We set s->mon to NULL in migrate_init. But we will use it
to search fd when do fd-migration, and it will cause qemu
crashed.
Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
migration.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index 4b17566..d094381 100644
--- a/migration.c
+++ b/migration.c
@@ -383,7 +383,7 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc)
s->bandwidth_limit = bandwidth_limit;
s->blk = blk;
s->shared = inc;
- s->mon = NULL;
+ s->mon = mon;
s->bandwidth_limit = bandwidth_limit;
s->state = MIG_STATE_SETUP;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] fix segfault on fd-migration starting
2011-11-07 2:34 [Qemu-devel] [PATCH] fix segfault on fd-migration starting Wen Congyang
@ 2011-11-07 11:22 ` Juan Quintela
0 siblings, 0 replies; 2+ messages in thread
From: Juan Quintela @ 2011-11-07 11:22 UTC (permalink / raw)
To: Wen Congyang; +Cc: qemu-devel
Wen Congyang <wency@cn.fujitsu.com> wrote:
> We set s->mon to NULL in migrate_init. But we will use it
> to search fd when do fd-migration, and it will cause qemu
> crashed.
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>
> ---
> migration.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/migration.c b/migration.c
> index 4b17566..d094381 100644
> --- a/migration.c
> +++ b/migration.c
> @@ -383,7 +383,7 @@ static MigrationState *migrate_init(Monitor *mon, int detach, int blk, int inc)
> s->bandwidth_limit = bandwidth_limit;
> s->blk = blk;
> s->shared = inc;
> - s->mon = NULL;
> + s->mon = mon;
> s->bandwidth_limit = bandwidth_limit;
> s->state = MIG_STATE_SETUP;
Problem is real.
Patch is wrong, because now we "resume" the monitor even when we are
doing detached migration. Looking into it.
Thanks, Juan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-07 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-07 2:34 [Qemu-devel] [PATCH] fix segfault on fd-migration starting Wen Congyang
2011-11-07 11:22 ` Juan Quintela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).