From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNNCQ-0007qL-Fx for qemu-devel@nongnu.org; Mon, 07 Nov 2011 06:17:16 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNNCM-00078Q-0j for qemu-devel@nongnu.org; Mon, 07 Nov 2011 06:17:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58045 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNNCL-00078K-R0 for qemu-devel@nongnu.org; Mon, 07 Nov 2011 06:17:05 -0500 Message-ID: <4EB7BE2B.5010703@suse.de> Date: Mon, 07 Nov 2011 12:16:59 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1320616132-21864-1-git-send-email-hpoussin@reactos.org> <1320616132-21864-2-git-send-email-hpoussin@reactos.org> In-Reply-To: <1320616132-21864-2-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/3] sonic: fix netcard reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: Anthony Liguori , qemu-devel@nongnu.org Am 06.11.2011 22:48, schrieb Herv=C3=A9 Poussineau: > From: Herv Poussineau Typo. At least to me it's not obvious why this is correct, so please add an explanatory patch description. Andreas > Signed-off-by: Herv=C3=A9 Poussineau > --- > hw/dp8393x.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/dp8393x.c b/hw/dp8393x.c > index cfec4cb..acb1604 100644 > --- a/hw/dp8393x.c > +++ b/hw/dp8393x.c > @@ -845,8 +845,7 @@ static void nic_reset(void *opaque) > s->regs[SONIC_CR] =3D SONIC_CR_RST | SONIC_CR_STP | SONIC_CR_RXDIS= ; > s->regs[SONIC_DCR] &=3D ~(SONIC_DCR_EXBUS | SONIC_DCR_LBR); > s->regs[SONIC_RCR] &=3D ~(SONIC_RCR_LB0 | SONIC_RCR_LB1 | SONIC_RC= R_BRD | SONIC_RCR_RNT); > - s->regs[SONIC_TCR] |=3D SONIC_TCR_NCRS | SONIC_TCR_PTX; > - s->regs[SONIC_TCR] &=3D ~SONIC_TCR_BCM; > + s->regs[SONIC_TCR] =3D SONIC_TCR_NCRS | SONIC_TCR_PTX; > s->regs[SONIC_IMR] =3D 0; > s->regs[SONIC_ISR] =3D 0; > s->regs[SONIC_DCR2] =3D 0; --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg