From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback
Date: Mon, 07 Nov 2011 14:56:13 +0100 [thread overview]
Message-ID: <4EB7E37D.4070903@redhat.com> (raw)
In-Reply-To: <4EB7E1D8.5090007@redhat.com>
On 11/07/2011 02:49 PM, Kevin Wolf wrote:
> > 2. eject with -f should really never be needed, but it does whatever is
> > needed to be able to follow up with a "change" command. It turns out it
> > is really "unlock" and "ask the guest to eject" combined, but that's the
> > implementation, not the model.
>
> Does this give different results than just asking the guest to eject
> without forcefully unlocking? I would expect that a guest that responds
> to the eject request would also unlock the drive. In which case I think
> eject without -f should be enough?
Only if the guest is not buggy (e.g. locks the tray but stops polling
for eject requests) and has not crashed.
Paolo
next prev parent reply other threads:[~2011-11-07 13:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 10:53 [Qemu-devel] [PATCH 0/5] My remaining block/SCSI patches for 1.0 Paolo Bonzini
2011-10-25 10:53 ` [Qemu-devel] [PATCH 1/8] scsi: do not call transfer_data after canceling a request Paolo Bonzini
2011-10-25 10:53 ` [Qemu-devel] [PATCH 2/8] scsi-disk: bump SCSIRequest reference count until aio completion runs Paolo Bonzini
2011-10-25 10:53 ` [Qemu-devel] [PATCH 3/8] scsi-generic: " Paolo Bonzini
2011-10-25 10:53 ` [Qemu-devel] [PATCH 4/8] scsi: push request restart to SCSIDevice Paolo Bonzini
2011-10-25 10:53 ` [Qemu-devel] [PATCH 5/8] scsi-disk: add scsi-block for device passthrough Paolo Bonzini
2011-10-28 17:04 ` Kevin Wolf
2011-10-25 10:53 ` [Qemu-devel] [PATCH 6/8] block: add eject request callback Paolo Bonzini
2011-10-28 17:21 ` Kevin Wolf
2011-10-29 7:46 ` Paolo Bonzini
2011-11-07 13:21 ` Markus Armbruster
2011-11-07 13:36 ` Paolo Bonzini
2011-11-07 13:49 ` Kevin Wolf
2011-11-07 13:56 ` Paolo Bonzini [this message]
2011-11-07 14:12 ` Kevin Wolf
2011-11-07 15:23 ` Markus Armbruster
2011-11-07 16:14 ` Paolo Bonzini
2011-11-07 16:50 ` [Qemu-devel] [PATCH 6/8 v2] " Paolo Bonzini
2011-11-08 13:18 ` Kevin Wolf
2011-10-25 10:53 ` [Qemu-devel] [PATCH 7/8] atapi: implement eject requests Paolo Bonzini
2011-10-25 10:53 ` [Qemu-devel] [PATCH 8/8] scsi-disk: " Paolo Bonzini
2011-10-27 11:45 ` [Qemu-devel] ping Re: [PATCH 0/5] My remaining block/SCSI patches for 1.0 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7E37D.4070903@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).