From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:42782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RNQ1b-00046A-EQ
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:18:17 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RNQ1V-0003S3-P3
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:18:11 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20711)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RNQ1V-0003Rv-I4
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:18:05 -0500
Message-ID: <4EB7E896.9010108@redhat.com>
Date: Mon, 07 Nov 2011 16:17:58 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1320663634-29453-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1320663634-29453-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem
	id
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>, qemu-devel@nongnu.org, kvm@vger.kernel.org

On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
> This patch removes the code lines which set the subsystem id for the
> emulated ac97 card to 8086:0000.  Due to the device id being zero the
> subsystem id isn't vaild anyway.  With the patch applied the sound card
> gets the default qemu subsystem id (1af4:1100) instead.
>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/ac97.c |    6 ------
>  1 files changed, 0 insertions(+), 6 deletions(-)
>
> diff --git a/hw/ac97.c b/hw/ac97.c
> index 6800af4..b43e435 100644
> --- a/hw/ac97.c
> +++ b/hw/ac97.c
> @@ -1305,12 +1305,6 @@ static int ac97_initfn (PCIDevice *dev)
>      c[PCI_BASE_ADDRESS_0 + 6] = 0x00;
>      c[PCI_BASE_ADDRESS_0 + 7] = 0x00;
>  
> -    c[PCI_SUBSYSTEM_VENDOR_ID] = 0x86;      /* svid subsystem vendor id rwo */
> -    c[PCI_SUBSYSTEM_VENDOR_ID + 1] = 0x80;
> -
> -    c[PCI_SUBSYSTEM_ID] = 0x00;      /* sid subsystem id rwo */
> -    c[PCI_SUBSYSTEM_ID + 1] = 0x00;
> -

This a guest ABI change.  Do we want -M support for it?

-- 
error compiling committee.c: too many arguments to function