From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47667) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNQM4-0007NO-DI for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:39:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNQLz-0006y5-Uw for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:39:20 -0500 Received: from mail-gx0-f173.google.com ([209.85.161.173]:51026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNQLz-0006xz-M6 for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:39:15 -0500 Received: by ggnp2 with SMTP id p2so1778753ggn.4 for ; Mon, 07 Nov 2011 06:39:15 -0800 (PST) Message-ID: <4EB7ED8B.4090505@codemonkey.ws> Date: Mon, 07 Nov 2011 08:39:07 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1320663634-29453-1-git-send-email-kraxel@redhat.com> <4EB7E896.9010108@redhat.com> <4EB7EC4A.90607@redhat.com> In-Reply-To: <4EB7EC4A.90607@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Takashi Iwai , Avi Kivity , kvm@vger.kernel.org, qemu-devel@nongnu.org On 11/07/2011 08:33 AM, Gerd Hoffmann wrote: > On 11/07/11 15:17, Avi Kivity wrote: >> On 11/07/2011 01:00 PM, Gerd Hoffmann wrote: >>> This patch removes the code lines which set the subsystem id for the >>> emulated ac97 card to 8086:0000. Due to the device id being zero the >>> subsystem id isn't vaild anyway. With the patch applied the sound card >>> gets the default qemu subsystem id (1af4:1100) instead. >> >> This a guest ABI change. Do we want -M support for it? > > Given that the old subsystem id isn't valid I'd say no unless someone > comes up with a good reason. Agreed. Regards, Anthony Liguori > > cheers, > Gerd > >