From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45813)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RNQRT-0001lq-CZ
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:45:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RNQRN-0007oa-FS
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:44:55 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:45178)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1RNQRN-0007oV-Bm
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 09:44:49 -0500
Received: by gyb11 with SMTP id 11so4464440gyb.4
	for <qemu-devel@nongnu.org>; Mon, 07 Nov 2011 06:44:48 -0800 (PST)
Message-ID: <4EB7EEDD.4090604@codemonkey.ws>
Date: Mon, 07 Nov 2011 08:44:45 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320663634-29453-1-git-send-email-kraxel@redhat.com>	<4EB7E896.9010108@redhat.com>
	<4EB7EC4A.90607@redhat.com> <4EB7EE62.7070805@redhat.com>
In-Reply-To: <4EB7EE62.7070805@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem
 id
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Takashi Iwai <tiwai@suse.de>, Gerd Hoffmann <kraxel@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

On 11/07/2011 08:42 AM, Avi Kivity wrote:
> On 11/07/2011 04:33 PM, Gerd Hoffmann wrote:
>> On 11/07/11 15:17, Avi Kivity wrote:
>>> On 11/07/2011 01:00 PM, Gerd Hoffmann wrote:
>>>> This patch removes the code lines which set the subsystem id for the
>>>> emulated ac97 card to 8086:0000.  Due to the device id being zero the
>>>> subsystem id isn't vaild anyway.  With the patch applied the sound card
>>>> gets the default qemu subsystem id (1af4:1100) instead.
>>>
>>> This a guest ABI change.  Do we want -M support for it?
>>
>> Given that the old subsystem id isn't valid I'd say no unless someone
>> comes up with a good reason.
>
> Do we know that Windows won't complain about it?

I thought the original motivation for the default subsystem ids was that some 
Windows test suite was explicitly complaining about having invalid subsystem ids?

Regards,

Anthony Liguori

>