From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Takashi Iwai <tiwai@suse.de>, Gerd Hoffmann <kraxel@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id
Date: Mon, 07 Nov 2011 16:50:15 +0200 [thread overview]
Message-ID: <4EB7F027.10209@redhat.com> (raw)
In-Reply-To: <4EB7EEDD.4090604@codemonkey.ws>
On 11/07/2011 04:44 PM, Anthony Liguori wrote:
>>>> This a guest ABI change. Do we want -M support for it?
>>>
>>> Given that the old subsystem id isn't valid I'd say no unless someone
>>> comes up with a good reason.
>>
>> Do we know that Windows won't complain about it?
>
>
> I thought the original motivation for the default subsystem ids was
> that some Windows test suite was explicitly complaining about having
> invalid subsystem ids?
I think so, but that's unrelated. The worry is that some DRM code
checksums your hardware and complains if it changed too much. Nothing
to do with the test suite.
The sense of Gerd's comment is reversed. We should preserve the ABI
unless there is a strong reason not to.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2011-11-07 14:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 11:00 [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id Gerd Hoffmann
2011-11-07 14:17 ` Avi Kivity
2011-11-07 14:33 ` Gerd Hoffmann
2011-11-07 14:39 ` Anthony Liguori
2011-11-07 14:42 ` Avi Kivity
2011-11-07 14:44 ` Anthony Liguori
2011-11-07 14:50 ` Avi Kivity [this message]
2011-11-07 14:53 ` Anthony Liguori
2011-11-07 15:00 ` Avi Kivity
2011-11-07 15:10 ` Gerd Hoffmann
2011-11-07 15:15 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB7F027.10209@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).