From: Rik van Riel <riel@redhat.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qemu_timedate_diff() shouldn't modify its argument.
Date: Mon, 07 Nov 2011 14:09:50 -0500 [thread overview]
Message-ID: <4EB82CFE.8080509@redhat.com> (raw)
In-Reply-To: <20111106160022.GF3225@redhat.com>
On 11/06/2011 11:00 AM, Gleb Natapov wrote:
> The caller of qemu_timedate_diff() does not expect that tm it passes to
> the function will be modified, but mktime() is destructive and modifies
> its argument. Pass a copy of tm to it and set tm_isdst so that mktime()
> will not rely on it since its value may be outdated.
Ohhh, nice catch.
> Signed-off-by: Gleb Natapov<gleb@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
next prev parent reply other threads:[~2011-11-07 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-06 16:00 [Qemu-devel] [PATCH] qemu_timedate_diff() shouldn't modify its argument Gleb Natapov
2011-11-07 19:09 ` Rik van Riel [this message]
2011-11-07 20:16 ` Ronen Hod
2011-11-08 7:36 ` Gleb Natapov
2011-11-08 17:24 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB82CFE.8080509@redhat.com \
--to=riel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).