From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43109)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RNXe6-0002OA-HG
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 17:26:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RNXe5-00080K-B1
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 17:26:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31111)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1RNXe5-00080B-3I
	for qemu-devel@nongnu.org; Mon, 07 Nov 2011 17:26:25 -0500
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA7MQORE024549
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 7 Nov 2011 17:26:24 -0500
Message-ID: <4EB85B0C.2070708@redhat.com>
Date: Tue, 08 Nov 2011 00:26:20 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1319109385-7927-1-git-send-email-pbonzini@redhat.com>
	<1319109385-7927-5-git-send-email-pbonzini@redhat.com>
	<4EB69949.4070503@redhat.com> <4EB6C312.2020402@redhat.com>
In-Reply-To: <4EB6C312.2020402@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read
	implementations
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

On 11/06/2011 07:25 PM, Paolo Bonzini wrote:
>
> Perhaps the failure is only reproduced 80-90% of the time and this
> screws up the bisection.

Correct, bad bisect.  It actually reproduces reliably, when the bisecter
is reliable.

The new candidate (disclaimer: unreliable bisecter) is:

commit a5c57d64aa61b700db444c4864a1da11f1165db6
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Mon Sep 12 14:40:36 2011 +0200

    qemu-timer: do not refer to runstate_is_running()
   
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.