From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNYN6-0002if-97 for qemu-devel@nongnu.org; Mon, 07 Nov 2011 18:12:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNYN5-00085b-CP for qemu-devel@nongnu.org; Mon, 07 Nov 2011 18:12:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNYN5-00085W-3s for qemu-devel@nongnu.org; Mon, 07 Nov 2011 18:12:55 -0500 Message-ID: <4EB865F3.9030809@redhat.com> Date: Tue, 08 Nov 2011 01:12:51 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1319109385-7927-1-git-send-email-pbonzini@redhat.com> <1319109385-7927-5-git-send-email-pbonzini@redhat.com> <4EB69949.4070503@redhat.com> <4EB6C312.2020402@redhat.com> <4EB85B0C.2070708@redhat.com> In-Reply-To: <4EB85B0C.2070708@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Anthony Liguori , qemu-devel On 11/08/2011 12:26 AM, Avi Kivity wrote: > On 11/06/2011 07:25 PM, Paolo Bonzini wrote: > > > > Perhaps the failure is only reproduced 80-90% of the time and this > > screws up the bisection. > > Correct, bad bisect. It actually reproduces reliably, when the bisecter > is reliable. > > The new candidate (disclaimer: unreliable bisecter) is: > > commit a5c57d64aa61b700db444c4864a1da11f1165db6 > Author: Paolo Bonzini > Date: Mon Sep 12 14:40:36 2011 +0200 > > qemu-timer: do not refer to runstate_is_running() > > Signed-off-by: Paolo Bonzini > > Fixed by 47113ab6b8c5659a, as Anthony pointed out on IRC. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.