From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:58686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNilG-0001Vs-10 for qemu-devel@nongnu.org; Tue, 08 Nov 2011 05:18:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNilB-0005qp-Br for qemu-devel@nongnu.org; Tue, 08 Nov 2011 05:18:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36308) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNilB-0005qk-1g for qemu-devel@nongnu.org; Tue, 08 Nov 2011 05:18:29 -0500 Message-ID: <4EB901EE.8070600@redhat.com> Date: Tue, 08 Nov 2011 11:18:22 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1320679989-8274-1-git-send-email-kraxel@redhat.com> <1320679989-8274-2-git-send-email-kraxel@redhat.com> <4EB80099.8050304@codemonkey.ws> <4EB8E38D.6040804@redhat.com> <4EB8FDD7.30909@redhat.com> In-Reply-To: <4EB8FDD7.30909@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Takashi Iwai , qemu-devel@nongnu.org, kvm@vger.kernel.org Hi, >>> Wouldn't it be better to have the subsystem vendor and device id be >>> configurable, set the default to the qemu subsystem ids, and then set it >>> to 8086:0000 for < 1.0? >> >> I don't want this being fully configurable just for the snake of >> backward compatibility with old qemu versions. > > I imagine some downstreams will want to configure it, but if we ever do > that, it's not for 1.0. And for that it would make more sense to make the default qemu subsystem id configurable, not the individual device IDs ... cheers, Gerd