From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNlWo-0000EO-UT for qemu-devel@nongnu.org; Tue, 08 Nov 2011 08:15:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNlWn-0006Yl-Ut for qemu-devel@nongnu.org; Tue, 08 Nov 2011 08:15:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24488) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNlWn-0006YY-JO for qemu-devel@nongnu.org; Tue, 08 Nov 2011 08:15:49 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA8DFmwi011467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 8 Nov 2011 08:15:49 -0500 Message-ID: <4EB92C41.1010908@redhat.com> Date: Tue, 08 Nov 2011 14:18:57 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1320684613-19540-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1320684613-19540-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/8 v2] block: add eject request callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, armbru@redhat.com Am 07.11.2011 17:50, schrieb Paolo Bonzini: > Recent versions of udev always keep the tray locked so that the kernel > can observe "eject request" events (aka tray button presses) even on > discs that aren't mounted. Add support for these events in the ATAPI > and SCSI cd drive device models. > > To let management cope with the behavior of udev, an event should also > be added for "tray opened/closed". This way, after issuing an "eject" > command, management can poll until the guests actually reacts to the > command. They can then issue the "change" command after the tray has been > opened, or try with "eject -f" after a (configurable?) timeout. However, > with this patch and the corresponding support in the device models, > at least it is possible to do a manual two-step eject+change sequence. > > Signed-off-by: Paolo Bonzini > --- > v1->v2: do not change the behavior of eject -f. Thanks, applied all three eject patches to the block-stable branch (for 1.0) Kevin