From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:34092)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jason.wessel@windriver.com>) id 1RNmvd-0003nF-VE
	for qemu-devel@nongnu.org; Tue, 08 Nov 2011 09:45:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jason.wessel@windriver.com>) id 1RNmvX-0000Gi-U6
	for qemu-devel@nongnu.org; Tue, 08 Nov 2011 09:45:33 -0500
Received: from mail.windriver.com ([147.11.1.11]:44082)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jason.wessel@windriver.com>) id 1RNmvX-0000GU-Jj
	for qemu-devel@nongnu.org; Tue, 08 Nov 2011 09:45:27 -0500
Message-ID: <4EB94080.7080806@windriver.com>
Date: Tue, 8 Nov 2011 08:45:20 -0600
From: Jason Wessel <jason.wessel@windriver.com>
MIME-Version: 1.0
References: <1320757252-29290-1-git-send-email-jason.wessel@windriver.com>
	<CABoDooMd5EGaEkEHg=0TtgV_BhjtBDHQ=VzwqQB3Y+_DB21iwQ@mail.gmail.com>
	<4EB93B29.9070204@windriver.com>
	<CAFEAcA_cCHv32qLJRJLH6A_0JwCk6Poceo-MvSmJZFvy9Ar8=Q@mail.gmail.com>
In-Reply-To: <CAFEAcA_cCHv32qLJRJLH6A_0JwCk6Poceo-MvSmJZFvy9Ar8=Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd
 SSE2 instruction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, qemu-devel@nongnu.org

On 11/08/2011 08:40 AM, Peter Maydell wrote:
> On 8 November 2011 14:22, Jason Wessel <jason.wessel@windriver.com> wrote:
>> +#define FPU_MIN(size, a, b) float ## size ## _lt(a, b, &env->sse_status) ? (a) : (b)
>> +#define FPU_MAX(size, a, b) float ## size ## _lt(b, a, &env->sse_status) ? (a) : (b)
> This will give the wrong answers for special cases involving +0, -0
> and NaNs. Check the intel architecture manual which says how these
> should work.
>
> (You can't use float*_min() and float*_max() either, as those have
> sane semantics and you need to implement the Intel ones here.)

Anyone out there know how to fix this the right way?

I do not have a point of reference as to how to properly implement this, I just stumbled on the fact it was completely broken since the switch from hardfloat to softfloat between qemu 0.14 and 0.15.  It certainly appears there is more to this problem than meets the eye. :-)

Jason.