qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Corey Bryant <coreyb@linux.vnet.ibm.com>
To: Zhi Yong Wu <zwu.kernel@gmail.com>
Cc: rmarwah@linux.vnet.ibm.com, aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 0/4] -net bridge: rootless bridge support for qemu
Date: Tue, 08 Nov 2011 10:37:15 -0500	[thread overview]
Message-ID: <4EB94CAB.5000705@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAEH94Lj81t_iaej8CBZQa_dehVgqvFoXn4SsTzyFoGvkkjBPrw@mail.gmail.com>



On 11/08/2011 01:46 AM, Zhi Yong Wu wrote:
> Why do you not develop one helper to set up bridge env for qemu guests
> when the host have no bridge interface?
>

I'm not sure that I understand your question.  I think the actual bridge 
setup should be left as an admin task, but the allocation/attaching of a 
tap device should be handled by the helper.

Regards,
Corey


> On Wed, Nov 2, 2011 at 1:13 AM, Corey Bryant<coreyb@linux.vnet.ibm.com>  wrote:
>> With qemu it is possible to run a guest from an unprivileged user but if
>> we wanted to communicate with the outside world we had to switch
>> to root.
>>
>> We address this problem by introducing a new network backend and a new
>> network option for -net tap.  This is less flexible when compared to
>> existing -net tap options because it relies on a helper with elevated
>> privileges to do the heavy lifting of allocating and attaching a tap
>> device to a bridge.  We use a special purpose helper because we don't
>> want to elevate the privileges of more generic tools like brctl.
>>
>> Qemu can be run with the default network helper as follows (in these cases
>> attaching the tap device to the default br0 bridge):
>>
>>      qemu -hda linux.img -net bridge -net nic
>> or:
>>      qemu -hda linux.img -net tap,helper=/usr/local/libexec/qemu-bridge-helper -net nic
>>
>> The default helper uses it's own ACL mechanism for access control, but
>> future network helpers could be developed, for example, to support PolicyKit
>> for access control.
>>
>> More details are included in individual patches.  The helper is broken into
>> a series of patches to improve reviewabilty.
>>
>> v2:
>>   - Updated signed-off-by's
>>   - Updated author's email
>>   - Set default bridge to br0
>>   - Added -net bridge
>>   - Updated ACL example
>>   - Moved from libcap to libcap-ng
>>   - Fail helper when libcap-ng not configured
>>
>> v3:
>>   - Use simple queue to store ACLs
>>   - Added goto cleanup to helper's main
>>   - Allow helper execution if libcap-ng not configured
>>   - Completed static analysis and memory analysis on helper
>>
>> v4:
>>   - Update has_vnet_hdr() to return bool
>>   - Update helper's main() to prevent errno clobbering
>>   - Let Kernel cleanup helper's file descriptors
>>
>> Corey Bryant (4):
>>   Add basic version of bridge helper
>>   Add access control support to qemu bridge helper
>>   Add cap reduction support to enable use as SUID
>>   Add support for net bridge
>>
>>   Makefile             |   12 ++-
>>   configure            |   37 +++++
>>   net.c                |   29 ++++-
>>   net.h                |    3 +
>>   net/tap.c            |  190 ++++++++++++++++++++++-
>>   net/tap.h            |    3 +
>>   qemu-bridge-helper.c |  407 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>   qemu-options.hx      |   73 ++++++++--
>>   8 files changed, 731 insertions(+), 23 deletions(-)
>>   create mode 100644 qemu-bridge-helper.c
>>
>> --
>> 1.7.3.4
>>
>>
>>
>
>
>

      reply	other threads:[~2011-11-08 15:38 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 17:13 [Qemu-devel] [PATCH v4 0/4] -net bridge: rootless bridge support for qemu Corey Bryant
2011-11-01 17:13 ` [Qemu-devel] [PATCH v4 1/4] Add basic version of bridge helper Corey Bryant
2011-11-02 10:58   ` Stefan Hajnoczi
2011-11-02 15:12     ` Corey Bryant
2011-11-03  7:54       ` Stefan Hajnoczi
2011-11-03 13:11         ` Corey Bryant
2011-11-01 17:13 ` [Qemu-devel] [PATCH v4 2/4] Add access control support to qemu " Corey Bryant
2011-11-01 17:13 ` [Qemu-devel] [PATCH v4 3/4] Add cap reduction support to enable use as SUID Corey Bryant
2011-11-01 17:13 ` [Qemu-devel] [PATCH v4 4/4] Add support for net bridge Corey Bryant
2011-11-02  8:12   ` Mark Wu
2011-11-02 15:52     ` Corey Bryant
2011-11-08  6:46 ` [Qemu-devel] [PATCH v4 0/4] -net bridge: rootless bridge support for qemu Zhi Yong Wu
2011-11-08 15:37   ` Corey Bryant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB94CAB.5000705@linux.vnet.ibm.com \
    --to=coreyb@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rmarwah@linux.vnet.ibm.com \
    --cc=zwu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).