From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNnll-0000w2-3q for qemu-devel@nongnu.org; Tue, 08 Nov 2011 10:39:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNnle-0003ZI-AY for qemu-devel@nongnu.org; Tue, 08 Nov 2011 10:39:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:30092) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNnle-0003Yz-2l for qemu-devel@nongnu.org; Tue, 08 Nov 2011 10:39:18 -0500 Message-ID: <4EB94D08.3010207@redhat.com> Date: Tue, 08 Nov 2011 16:38:48 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <20111107203255.GF24234@thunk.org> <4EB85969.2010108@codemonkey.ws> <12F471C8-2CF3-4CD7-B417-C8CC898669E6@mit.edu> <20111108093225.GB32533@elte.hu> <20111108125609.GA14272@ghostprotocols.net> <4EB9315A.10806@redhat.com> <20111108143228.GC14272@ghostprotocols.net> In-Reply-To: <20111108143228.GC14272@ghostprotocols.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/ List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Arnaldo Carvalho de Melo Cc: Alexander Graf , Theodore Tso , Peter Zijlstra , "kvm@vger.kernel.org list" , qemu-devel Developers , Vince Weaver , "linux-kernel@vger.kernel.org List" , Pekka Enberg , Blue Swirl , Avi Kivity , =?ISO-8859-1?Q?Am=E9rico_Wang?= , Ingo Molnar , Linus Torvalds , Thomas Gleixner Hi, >> documentation: Where the heck is the perf config file documented, other >> than source code? Reading the parser to figure how the config file is >> supposed to look like really isn't fun :( > >> I'm looking for a way to disable the colors in the perf report tui. Or >> configure them into something readable. No, light green on light gray >> which is used by default isn't readable. > > That was fixed in 3.2-rc1, where also we have: Very cutting edge. /me pulls. > [acme@felicio linux]$ cat tools/perf/Documentation/perfconfig.example Present now, thanks. > [colors] > > # These were the old defaults > top = red, lightgray > medium = green, lightgray > normal = black, lightgray > selected = lightgray, magenta > code = blue, lightgray Seems to have no effect, guess the distro perf binary is too old for that (RHEL-6). > [tui] > > report = off That works. I don't want turn off the tui altogether though, I actually like the interactive expanding+collapsing of the call graphs. I just want turn off the colors. perf_color_default_config() in util/color.c seems to lookup a "color.ui" config variable. Can I set that somehow? Tried ui= in a [color] section -- no effect. > By default the TUI now uses whatever color is configured for your xterm, > not something fixed as in the past, which was a common source of > complaints, that, unfortunately I only heard indirectly :-\ > > Ah, if you still need to configure the colors, use "default" so that it > will use whatever is the color configured in your > xterm/gnome-terminal/whatever profile. > > For reference, the default set of colors now is (from > tools/perf/util/ui/browser.c): > > static struct ui_browser__colorset { > const char *name, *fg, *bg; > int colorset; > } ui_browser__colorsets[] = { > { > .colorset = HE_COLORSET_TOP, > .name = "top", > .fg = "red", > .bg = "default", Bad idea IMO. Setting only one of foreground+background gives pretty much unpredictable results. My xterms have different background colors, the ones with a root shell happen to have a (dark) red background. Which results in red-on-dark-red text. Not good. I'd strongly suggest to either set both background and foreground to default or to set both to a specific color. When doing the latter make sure the colors have enougth contrast so they are readable. cheers, Gerd