From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNpOn-0000Xn-Ke for qemu-devel@nongnu.org; Tue, 08 Nov 2011 12:23:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNpOm-0000Da-Kp for qemu-devel@nongnu.org; Tue, 08 Nov 2011 12:23:49 -0500 Received: from mail-gy0-f173.google.com ([209.85.160.173]:50445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNpOm-0000DV-H8 for qemu-devel@nongnu.org; Tue, 08 Nov 2011 12:23:48 -0500 Received: by gyb11 with SMTP id 11so871929gyb.4 for ; Tue, 08 Nov 2011 09:23:48 -0800 (PST) Message-ID: <4EB965A0.5050701@codemonkey.ws> Date: Tue, 08 Nov 2011 11:23:44 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1320332422-2457-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1320332422-2457-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 11/03/2011 10:00 AM, Paolo Bonzini wrote: > sgabios hasn't gotten a lot of coverage since it was not shipped. For 1.0, > let's disable the automatic loading of the option ROM in -nographic > mode. We can put it back for 1.1. > > Signed-off-by: Paolo Bonzini Applied. Thanks. Regards, Anthony Liguori > --- > Requested by Anthony on IRC. > > hw/pc.c | 9 --------- > 1 files changed, 0 insertions(+), 9 deletions(-) > > diff --git a/hw/pc.c b/hw/pc.c > index eb4c2d8..1024465 100644 > --- a/hw/pc.c > +++ b/hw/pc.c > @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus) > isa_vga_init(); > } > } > - > - /* > - * sga does not suppress normal vga output. So a machine can have both a > - * vga card and sga manually enabled. Output will be seen on both. > - * For nographic case, sga is enabled at all times > - */ > - if (display_type == DT_NOGRAPHIC) { > - isa_create_simple("sga"); > - } > } > > static void cpu_request_exit(void *opaque, int irq, int level)