* [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic
@ 2011-11-03 15:00 Paolo Bonzini
2011-11-08 17:23 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2011-11-03 15:00 UTC (permalink / raw)
To: qemu-devel
sgabios hasn't gotten a lot of coverage since it was not shipped. For 1.0,
let's disable the automatic loading of the option ROM in -nographic
mode. We can put it back for 1.1.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
Requested by Anthony on IRC.
hw/pc.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index eb4c2d8..1024465 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus)
isa_vga_init();
}
}
-
- /*
- * sga does not suppress normal vga output. So a machine can have both a
- * vga card and sga manually enabled. Output will be seen on both.
- * For nographic case, sga is enabled at all times
- */
- if (display_type == DT_NOGRAPHIC) {
- isa_create_simple("sga");
- }
}
static void cpu_request_exit(void *opaque, int irq, int level)
--
1.7.6.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic
2011-11-03 15:00 [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic Paolo Bonzini
@ 2011-11-08 17:23 ` Anthony Liguori
2011-12-02 16:33 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Anthony Liguori @ 2011-11-08 17:23 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On 11/03/2011 10:00 AM, Paolo Bonzini wrote:
> sgabios hasn't gotten a lot of coverage since it was not shipped. For 1.0,
> let's disable the automatic loading of the option ROM in -nographic
> mode. We can put it back for 1.1.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> Requested by Anthony on IRC.
>
> hw/pc.c | 9 ---------
> 1 files changed, 0 insertions(+), 9 deletions(-)
>
> diff --git a/hw/pc.c b/hw/pc.c
> index eb4c2d8..1024465 100644
> --- a/hw/pc.c
> +++ b/hw/pc.c
> @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus)
> isa_vga_init();
> }
> }
> -
> - /*
> - * sga does not suppress normal vga output. So a machine can have both a
> - * vga card and sga manually enabled. Output will be seen on both.
> - * For nographic case, sga is enabled at all times
> - */
> - if (display_type == DT_NOGRAPHIC) {
> - isa_create_simple("sga");
> - }
> }
>
> static void cpu_request_exit(void *opaque, int irq, int level)
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic
2011-11-08 17:23 ` Anthony Liguori
@ 2011-12-02 16:33 ` Paolo Bonzini
2011-12-02 16:34 ` Anthony Liguori
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Bonzini @ 2011-12-02 16:33 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On 11/08/2011 06:23 PM, Anthony Liguori wrote:
> On 11/03/2011 10:00 AM, Paolo Bonzini wrote:
>> sgabios hasn't gotten a lot of coverage since it was not shipped. For
>> 1.0,
>> let's disable the automatic loading of the option ROM in -nographic
>> mode. We can put it back for 1.1.
>>
>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
> Applied. Thanks.
Can you please revert it for 1.1? Thanks!
Paolo
>> ---
>> Requested by Anthony on IRC.
>>
>> hw/pc.c | 9 ---------
>> 1 files changed, 0 insertions(+), 9 deletions(-)
>>
>> diff --git a/hw/pc.c b/hw/pc.c
>> index eb4c2d8..1024465 100644
>> --- a/hw/pc.c
>> +++ b/hw/pc.c
>> @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus)
>> isa_vga_init();
>> }
>> }
>> -
>> - /*
>> - * sga does not suppress normal vga output. So a machine can have both a
>> - * vga card and sga manually enabled. Output will be seen on both.
>> - * For nographic case, sga is enabled at all times
>> - */
>> - if (display_type == DT_NOGRAPHIC) {
>> - isa_create_simple("sga");
>> - }
>> }
>>
>> static void cpu_request_exit(void *opaque, int irq, int level)
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic
2011-12-02 16:33 ` Paolo Bonzini
@ 2011-12-02 16:34 ` Anthony Liguori
0 siblings, 0 replies; 4+ messages in thread
From: Anthony Liguori @ 2011-12-02 16:34 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On 12/02/2011 10:33 AM, Paolo Bonzini wrote:
> On 11/08/2011 06:23 PM, Anthony Liguori wrote:
>> On 11/03/2011 10:00 AM, Paolo Bonzini wrote:
>>> sgabios hasn't gotten a lot of coverage since it was not shipped. For
>>> 1.0,
>>> let's disable the automatic loading of the option ROM in -nographic
>>> mode. We can put it back for 1.1.
>>>
>>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>>
>> Applied. Thanks.
>
> Can you please revert it for 1.1? Thanks!
Can you send a patch?
Regards,
Anthony Liguori
>
> Paolo
>
>>> ---
>>> Requested by Anthony on IRC.
>>>
>>> hw/pc.c | 9 ---------
>>> 1 files changed, 0 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/hw/pc.c b/hw/pc.c
>>> index eb4c2d8..1024465 100644
>>> --- a/hw/pc.c
>>> +++ b/hw/pc.c
>>> @@ -1104,15 +1104,6 @@ void pc_vga_init(PCIBus *pci_bus)
>>> isa_vga_init();
>>> }
>>> }
>>> -
>>> - /*
>>> - * sga does not suppress normal vga output. So a machine can have both a
>>> - * vga card and sga manually enabled. Output will be seen on both.
>>> - * For nographic case, sga is enabled at all times
>>> - */
>>> - if (display_type == DT_NOGRAPHIC) {
>>> - isa_create_simple("sga");
>>> - }
>>> }
>>>
>>> static void cpu_request_exit(void *opaque, int irq, int level)
>>
>>
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-02 16:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-03 15:00 [Qemu-devel] [PATCH 1.0] disable automatic loading of sgabios when -nographic Paolo Bonzini
2011-11-08 17:23 ` Anthony Liguori
2011-12-02 16:33 ` Paolo Bonzini
2011-12-02 16:34 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).