From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RNtY6-0006n8-KU
	for qemu-devel@nongnu.org; Tue, 08 Nov 2011 16:49:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RNtY5-0004d2-B6
	for qemu-devel@nongnu.org; Tue, 08 Nov 2011 16:49:42 -0500
Received: from cantor2.suse.de ([195.135.220.15]:56558 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RNtY5-0004ch-15
	for qemu-devel@nongnu.org; Tue, 08 Nov 2011 16:49:41 -0500
Message-ID: <4EB9A3ED.4050801@suse.de>
Date: Tue, 08 Nov 2011 22:49:33 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1320757785-20894-1-git-send-email-chenwj@iis.sinica.edu.tw>
	<m3ty6ea7zh.fsf@neno.neno> <20111108170856.GA5179@cs.nctu.edu.tw>
In-Reply-To: <20111108170856.GA5179@cs.nctu.edu.tw>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a
 target
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?6Zmz6Z+L5Lu7?= <chenwj@iis.sinica.edu.tw>
Cc: qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

Am 08.11.2011 18:08, schrieb =E9=99=B3=E9=9F=8B=E4=BB=BB:
>> Have you build this?  without this files qemu is not going to work.
>> Perhaps the naming is wrong, and we should change common-obj to
>> something else, but it is still needed to get things working as
>> expected.
>=20
>   I found the line below in Makefile,
>=20
> $(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y) sub=
dir-libdis
>=20
>   I guess you ran into trouble while building *-softmmu? I think we can
> just remove "libqemu_common.a:" from the comment of common-obj-y and
> leave the rest part alone.

Yes, please. I believe I'm the one to blame, I replaced the .a target
with these lists of .o files to fix the build on OpenSolaris after
constructors was introduced.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg