qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Harsh Bora <harsh@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org,
	"Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/analyse-9p-simpletrace.py: Add symbolic names for 9p operations.
Date: Wed, 09 Nov 2011 14:10:47 +0530	[thread overview]
Message-ID: <4EBA3C8F.7040405@linux.vnet.ibm.com> (raw)
In-Reply-To: <871uth90j7.fsf@linux.vnet.ibm.com>

On 11/09/2011 01:43 PM, Aneesh Kumar K.V wrote:
> On Wed,  9 Nov 2011 11:55:51 +0530, Harsh Prateek Bora<harsh@linux.vnet.ibm.com>  wrote:
>> Currently, we just print the numerical value of 9p operation identifier in
>> case of RERROR which is less meaningful for readability. Mapping 9p
>> operation ids to symbolic names provides a better tracelog:
>>
>> 	RERROR (tag = 1 , id = TWALK , err = 2 )
>> 	RERROR (tag = 1 , id = TUNLINKAT , err = 39 )
>
> It would be nice to map that err to a string. os.strerror(err) may be ?
>

makes sense, however os.strerror prints multi word text explaining the 
error and not just the symbolic word, hope its okay:

RERROR (tag = 1 , id = TWALK , err = No such file or directory )
RERROR (tag = 1 , id = TUNLINKAT , err = Directory not empty )

will update in v2.

>
>>
>> This patch provides a dictionary of all possible 9p operation symbols mapped
>> to their numerical identifiers which are likely to be used in future at
>> various places in this script.
>>
>> Signed-off-by: Harsh Prateek Bora<harsh@linux.vnet.ibm.com>
>> ---
>
> -aneesh
>
>

      reply	other threads:[~2011-11-09  8:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09  6:25 [Qemu-devel] [PATCH] scripts/analyse-9p-simpletrace.py: Add symbolic names for 9p operations Harsh Prateek Bora
2011-11-09  8:13 ` Aneesh Kumar K.V
2011-11-09  8:40   ` Harsh Bora [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBA3C8F.7040405@linux.vnet.ibm.com \
    --to=harsh@linux.vnet.ibm.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).