qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Benjamin <mlspirat42@gmail.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Support for UDP unicast network backend
Date: Wed, 09 Nov 2011 11:41:46 +0100	[thread overview]
Message-ID: <4EBA58EA.3010102@suse.de> (raw)
In-Reply-To: <4EBA93FF.4050801@gmail.com>

Am 09.11.2011 15:53, schrieb Benjamin:
> On 11/09/11 15:26, Benjamin wrote:
>> Oh, I forgot to remove a line from the old patch, when I wanted to
>> introduce -netdev udp. Now it's just -net[dev] socket.
>> Here's the updated patch, my apologies.
>> It didn't break anything, it's just useless, use this instead.
>>
>>
> 
> I sent the old one again...
> This one is correct.
> Sorry for the noise.
> 
> Support for UDP unicast network backend
> 
> Signed-off-by: Benjamin MARSILI <marsil_b@epitech.eu>
> Acked-by: Jan Kiszka<jan.kiszka@siemens.com>
> 
> ---

Actually, revised patches like any others should be submitted with
git-send-email. That is, make the description commit'able and put all
personal comments, questions, quotations below the --- line. That way it
can be applied with git-am. Also use --subject-prefix="PATCH v2" and so
on to identify different patch versions.
I'd also suggest to prefix your subject with "net: " to make clear which
part it touches.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2011-11-09 10:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-06 17:08 [Qemu-devel] Integrating Dynamips and GNS3 UDP tunnels (Patches) Benjamin Epitech
2011-10-07  8:35 ` Jan Kiszka
2011-10-08 17:31   ` Benjamin
2011-10-08  9:29     ` Jan Kiszka
2011-10-09 17:02       ` Benjamin
2011-11-06 20:55       ` [Qemu-devel] [PATCH] Support for UDP unicast network backend Benjamin
2011-11-06 13:54         ` Jan Kiszka
2011-11-07 14:01           ` Benjamin
2011-11-07 11:23             ` Jan Kiszka
2011-11-07 22:03               ` Benjamin
2011-11-08 10:52                 ` Jan Kiszka
2011-11-09 14:26                   ` Benjamin
2011-11-09 14:53                     ` Benjamin
2011-11-09 10:41                       ` Andreas Färber [this message]
2011-11-24  1:02                         ` [Qemu-devel] [PATCH v2] " Benjamin
2011-11-24  9:13                           ` Stefan Hajnoczi
2011-11-06 14:28         ` [Qemu-devel] [PATCH] " Benjamin Epitech
2011-10-08  9:37     ` [Qemu-devel] Integrating Dynamips and GNS3 UDP tunnels (Patches) Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EBA58EA.3010102@suse.de \
    --to=afaerber@suse.de \
    --cc=jan.kiszka@web.de \
    --cc=mlspirat42@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).