From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Benoît Canet" <benoit.canet@gmail.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features.
Date: Wed, 09 Nov 2011 15:41:26 +0100 [thread overview]
Message-ID: <4EBA9116.8010909@suse.de> (raw)
In-Reply-To: <CAFEAcA9-cxQKdW1hQ7ioGk7BFTWFfKt=MinsnGXa0NY1W8y9+A@mail.gmail.com>
Am 09.11.2011 15:06, schrieb Peter Maydell:
> 2011/11/9 Andreas Färber <afaerber@suse.de>:
>> I'm wondering if this translation table were better placed in
>> target-arm/helper.c where we fiddle with the features in the first
>> place. We could loop through all features here and call a function that
>> returns the hwcap or 0 and |= it. Me and others will be adding new
>> features and we'll risk adapting this here.
>
> Hmm. It's really linux-specific so there's a good argument for
> leaving it in linux-user. On the other hand I did just add some
> extra features (arm div, vfpv4) without fixing the hwcaps so I
> see your point...
>
> Maybe we should just have a comment in cpu.h next to the
> arm_features enum?
That might do, too.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2011-11-09 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 13:04 [Qemu-devel] [PATCH] Fix : [Bug 887516] [NEW] VFP support reported for the PXA270 Benoît Canet
2011-11-09 13:04 ` [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP reflected cpu features Benoît Canet
2011-11-09 13:34 ` Andreas Färber
2011-11-09 13:51 ` Benoît Canet
2011-11-09 14:06 ` Peter Maydell
2011-11-09 14:41 ` Andreas Färber [this message]
2011-11-09 14:01 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBA9116.8010909@suse.de \
--to=afaerber@suse.de \
--cc=benoit.canet@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).