From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45452)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RO9LQ-0003wG-7T
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 09:41:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RO9LK-0003Cs-7V
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 09:41:40 -0500
Received: from cantor2.suse.de ([195.135.220.15]:56500 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RO9LK-0003Ck-2s
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 09:41:34 -0500
Message-ID: <4EBA9116.8010909@suse.de>
Date: Wed, 09 Nov 2011 15:41:26 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1320843872-2402-1-git-send-email-benoit.canet@gmail.com>
	<1320843872-2402-2-git-send-email-benoit.canet@gmail.com>
	<4EBA8171.50505@suse.de>
	<CAFEAcA9-cxQKdW1hQ7ioGk7BFTWFfKt=MinsnGXa0NY1W8y9+A@mail.gmail.com>
In-Reply-To: <CAFEAcA9-cxQKdW1hQ7ioGk7BFTWFfKt=MinsnGXa0NY1W8y9+A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] arm-linux-user: fix elfload.c's AT_HWCAP
 reflected cpu features.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit.canet@gmail.com>, qemu-devel@nongnu.org

Am 09.11.2011 15:06, schrieb Peter Maydell:
> 2011/11/9 Andreas F=C3=A4rber <afaerber@suse.de>:
>> I'm wondering if this translation table were better placed in
>> target-arm/helper.c where we fiddle with the features in the first
>> place. We could loop through all features here and call a function tha=
t
>> returns the hwcap or 0 and |=3D it. Me and others will be adding new
>> features and we'll risk adapting this here.
>=20
> Hmm. It's really linux-specific so there's a good argument for
> leaving it in linux-user. On the other hand I did just add some
> extra features (arm div, vfpv4) without fixing the hwcaps so I
> see your point...
>=20
> Maybe we should just have a comment in cpu.h next to the
> arm_features enum?

That might do, too.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg