From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO9yE-0003IV-O6 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 10:21:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RO9yA-0003H6-4x for qemu-devel@nongnu.org; Wed, 09 Nov 2011 10:21:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RO9y9-0003Gu-O2 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 10:21:42 -0500 Message-ID: <4EBA9A7E.7030209@redhat.com> Date: Wed, 09 Nov 2011 17:21:34 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1319540983-4248-1-git-send-email-benoit.canet@gmail.com> <1319540983-4248-5-git-send-email-benoit.canet@gmail.com> <4EB8CD52.1000008@redhat.com> <4EB91EDE.7070909@redhat.com> <4EB922DD.6040309@redhat.com> <4EB933BE.7080503@codemonkey.ws> <4EB93ED9.6060105@redhat.com> <4EB944EE.9090304@codemonkey.ws> <4EB9477D.5010804@redhat.com> <4EB94B9F.5040102@codemonkey.ws> <4EB964AC.6000605@redhat.com> <4EBA90D8.8040707@codemonkey.ws> <4EBA96BD.5050904@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= , qemu-devel@nongnu.org, quintela@redhat.com On 11/09/2011 05:20 PM, Peter Maydell wrote: > From a really quick glance at Avi's memory/mutators branch I think > the long term plan would be that rather than mapping/unmapping the > region we just call memory_region_set_enabled() which would cope > happily with being asked to enable an already-enabled region. > Is that right? It is. Call it from both the _write() callback that sets the register, and from post_load(), and you're done. -- error compiling committee.c: too many arguments to function