From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48359)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ROBPv-0000cl-Nq
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 11:54:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ROBPr-0006YV-MN
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 11:54:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:16051)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1ROBPr-0006YN-Cd
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 11:54:23 -0500
Message-ID: <4EBAB0FA.1070001@redhat.com>
Date: Wed, 09 Nov 2011 17:57:30 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <4EB91FA20200009100076E0E@novprvoes0310.provo.novell.com>
	<4EBA4BEC.5040401@redhat.com>
	<4EBA3D0D0200009100076EF0@novprvoes0310.provo.novell.com>
	<4EBAA30D.1090209@redhat.com>
	<4EBA48A90200009100076EF6@novprvoes0310.provo.novell.com>
In-Reply-To: <4EBA48A90200009100076EF6@novprvoes0310.provo.novell.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] block: Fix vpc initialization of the
 Dynamic Disk Header
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Charles Arnold <carnold@suse.com>
Cc: qemu-devel@nongnu.org

Am 09.11.2011 17:32, schrieb Charles Arnold:
>>>> On 11/9/2011 at 08:58 AM, in message <4EBAA30D.1090209@redhat.com>, Kevin Wolf
> <kwolf@redhat.com> wrote: 
>>
>> Right, I'm not arguing that your change is wrong. What I'm asking for is
>> just something like:
>>
>> -    dyndisk_header->data_offset = be64_to_cpu(0xFFFFFFFF);
>> +    /* Note: The spec is actually wrong here, it says 0xFFFFFFFF, but
>> MS tools expect all 64 bits to be set */
>> +    dyndisk_header->data_offset = be64_to_cpu(0xFFFFFFFFFFFFFFFFULL);
>>
>> Kevin
> 
> Ok, I had the header comment on the brain, not a code comment. 
> Here is the revised patch.
> 
> - Charles
> 
> 
> The Data Offset field in the Dynamic Disk Header is an 8 byte field.
> Although the specification (2006-10-11) gives an example of initializing
> only the first 4 bytes, images generated by Microsoft on Windows initialize
> all 8 bytes.
> 
> Failure to initialize all 8 bytes results in errors from utilities
> like Citrix's vhd-util which checks specifically for the proper Data
> Offset field initialization.
> 
> Signed-off-by: Charles Arnold <carnold@suse.com>

Thanks, applied to the block-stable branch (for 1.0)

Kevin