From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROCRx-0004sq-SV for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:00:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROCRt-0004ep-8G for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:00:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28815) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROCRs-0004ee-Tz for qemu-devel@nongnu.org; Wed, 09 Nov 2011 13:00:33 -0500 Message-ID: <4EBABFBA.5070106@redhat.com> Date: Wed, 09 Nov 2011 20:00:26 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1320846276-19659-1-git-send-email-avi@redhat.com> <4EBABEC4.2080303@codemonkey.ws> In-Reply-To: <4EBABEC4.2080303@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] i386: derive '-cpu host' from KVM_GET_SUPPORTED_CPUID List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 11/09/2011 07:56 PM, Anthony Liguori wrote: > On 11/09/2011 07:44 AM, Avi Kivity wrote: >> The fact that a host cpu supports a feature doesn't mean that QEMU >> and KVM >> will also support it, yet -cpuid host brings host features wholesale. >> >> We need to whitelist each feature separately to make sure we support it. >> This patch adds KVM whitelisting (by simply using >> KVM_GET_SUPPORTED_CPUID >> instead of the CPUID instruction). >> >> Signed-off-by: Avi Kivity > > This seems like a 1.0 candidate, yes? There is a distinct possibility this will uncover bugs in kvm's KVM_GET_SUPPORTED_CPUID. Those won't be qemu bugs, so I think it's good for 1.0. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.