From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:56321)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROE5F-0005J8-5k
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:45:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROE5A-0000iU-Dy
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:45:17 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:63880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1ROE5A-0000Z6-B6
	for qemu-devel@nongnu.org; Wed, 09 Nov 2011 14:45:12 -0500
Received: by mail-yx0-f173.google.com with SMTP id r8so1194122yen.4
	for <qemu-devel@nongnu.org>; Wed, 09 Nov 2011 11:45:12 -0800 (PST)
Message-ID: <4EBAD844.90902@codemonkey.ws>
Date: Wed, 09 Nov 2011 13:45:08 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1320860543-9596-1-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1320860543-9596-1-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to
 fix 8 bit NAND writes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, patches@linaro.org

On 11/09/2011 11:42 AM, Peter Maydell wrote:
> Add missing 'break' statements which would have meant that writing
> to an 8 bit NAND device was broken. Spotted by Coverity (see bug
> 887883).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> This is an embarrassing bug...
>
>   hw/omap_gpmc.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
> index 7fc82a2..414f9f5 100644
> --- a/hw/omap_gpmc.c
> +++ b/hw/omap_gpmc.c
> @@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
>               nand_setio(dev, (value>>  24)&  0xff);
>               break;
>           }
> +        break;
>       case OMAP_GPMC_16BIT:
>           switch (size) {
>           case 1:
> @@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
>               nand_setio(dev, (value>>  16)&  0xffff);
>               break;
>           }
> +        break;
>       }
>   }
>