From: Anthony Liguori <anthony@codemonkey.ws>
To: Alexander Graf <agraf@suse.de>
Cc: "Stefan Weil" <sw@weilnetz.de>,
"Luiz Capitulino" <lcapitulino@redhat.com>,
"Andreas Färber" <afaerber@suse.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp
Date: Wed, 09 Nov 2011 17:38:54 -0600 [thread overview]
Message-ID: <4EBB0F0E.4000908@codemonkey.ws> (raw)
In-Reply-To: <C21FDC21-19A4-43B0-AB32-F672467BB4A6@suse.de>
On 11/09/2011 05:12 PM, Alexander Graf wrote:
>
>> We have been using it that way in the past and I am not aware of a patch
>> that removed ancient cleanups, so it's good practice to keep it working
>> that way.
>>
>> When I do a git pull I don't know whether or what it may bring. Always
>> doing make clean just-in-case is simply unproductive.
>
> I agree. After a git pull the worst case I want to see is that I need to do make defconfig clean. Anything that doesn't clean up this way leaves my build in a broken state, meaning it's a bug to me.
Sorry, but there's no way around this. This doesn't happen often and emails are
almost always sent ahead of time.
It's impossible to test something like this because by definition, the code no
longer lives in the tree.
Regards,
Anthony Liguori
>
> Alex
>
>>
>> Regards,
>> Andreas
>>
>> --
>> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
>> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
>
next prev parent reply other threads:[~2011-11-09 23:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 1:38 [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp Alexander Graf
2011-11-09 5:58 ` Stefan Weil
2011-11-09 10:27 ` Andreas Färber
2011-11-09 12:47 ` Luiz Capitulino
2011-11-09 23:45 ` Alexander Graf
2011-11-10 0:51 ` Anthony Liguori
2011-11-10 6:33 ` Stefan Weil
2011-11-10 9:46 ` Andreas Färber
2011-11-09 17:57 ` Anthony Liguori
2011-11-09 18:01 ` Andreas Färber
2011-11-09 23:12 ` Alexander Graf
2011-11-09 23:38 ` Anthony Liguori [this message]
2011-11-09 23:44 ` Alexander Graf
2011-11-10 0:47 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB0F0E.4000908@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).