From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:48419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROHjP-0006PC-Mr for qemu-devel@nongnu.org; Wed, 09 Nov 2011 18:39:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ROHjO-0008MQ-54 for qemu-devel@nongnu.org; Wed, 09 Nov 2011 18:38:59 -0500 Received: from mail-iy0-f173.google.com ([209.85.210.173]:46260) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ROHjO-0008MM-0q for qemu-devel@nongnu.org; Wed, 09 Nov 2011 18:38:58 -0500 Received: by iakk32 with SMTP id k32so2585689iak.4 for ; Wed, 09 Nov 2011 15:38:57 -0800 (PST) Message-ID: <4EBB0F0E.4000908@codemonkey.ws> Date: Wed, 09 Nov 2011 17:38:54 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1320802728-21841-1-git-send-email-agraf@suse.de> <4EBA16A1.9090703@weilnetz.de> <4EBA558A.20707@suse.de> <4EBABF07.6090307@codemonkey.ws> <4EBABFE1.4070200@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] pci-stub: fix compile breakage with qmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Stefan Weil , Luiz Capitulino , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , "qemu-devel@nongnu.org" On 11/09/2011 05:12 PM, Alexander Graf wrote: > >> We have been using it that way in the past and I am not aware of a patch >> that removed ancient cleanups, so it's good practice to keep it working >> that way. >> >> When I do a git pull I don't know whether or what it may bring. Always >> doing make clean just-in-case is simply unproductive. > > I agree. After a git pull the worst case I want to see is that I need to do make defconfig clean. Anything that doesn't clean up this way leaves my build in a broken state, meaning it's a bug to me. Sorry, but there's no way around this. This doesn't happen often and emails are almost always sent ahead of time. It's impossible to test something like this because by definition, the code no longer lives in the tree. Regards, Anthony Liguori > > Alex > >> >> Regards, >> Andreas >> >> -- >> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany >> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg >